requirements: Relax protobuf version constraint #2043
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All generated code since 3.20.0 will be supported until at least 8.x.y. https://protobuf.dev/support/cross-version-runtime-guarantee/ protocolbuffers/protobuf@1af7fd4
juergbi
requested review from
BenjaminSchubert,
abderrahim,
cs-shadow and
gtristan
as code owners
This was referenced Aug 15, 2025
Contributor
|
I would revert #2017 wholesale, but given this new info it would be nice to have your changes on top of that. |
… regenerated" This reverts commit 5e9eb76.
We need to make sure that the right version of `grpcio-tools` is used to regenerate protobuf and grpc code to not depend on too recent versions of protobuf or grpc. Define a tox environment to make this more convenient and less error-prone.
Contributor
Author
|
I've reverted the remaining part of #2017. And I've added a tox environment |
abderrahim
approved these changes
Aug 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All generated code since 3.20.0 will be supported until at least 8.x.y.
https://protobuf.dev/support/cross-version-runtime-guarantee/
protocolbuffers/protobuf@1af7fd4