_protos: regenerate with grpcio-tools 1.73 #2022
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abderrahim
requested review from
BenjaminSchubert,
cs-shadow,
gtristan and
juergbi
as code owners
abderrahim
force-pushed
the
abderrahim/protobuf-6
branch
2 times, most recently
from
d6a527d to
f713243
Compare
abderrahim
force-pushed
the
abderrahim/protobuf-6
branch
2 times, most recently
from
a7d2f21 to
0a58032
Compare
It's monkey patching something that is no longer used by buildstream
This makes it compatible with protobuf 30+, a.k.a. 6, a.k.a. 6.30+
abderrahim
force-pushed
the
abderrahim/protobuf-6
branch
from
0a58032 to
5d93960
Compare
Contributor
|
According to https://protobuf.dev/support/cross-version-runtime-guarantee/:
I.e., there should be long forward compatibility of generated Python code. Assuming this is correct, we should not upgrade grpcio-tools for code generation. We should instead loosen the protobuf requirement to allow use with protobuf 6 and later. Runtime warnings have been reported, though, in #2042. We should investigate the reason for these warnings before taking any action. |
Contributor
|
The protobuf warning has been removed upstream: protocolbuffers/protobuf@1af7fd4 |
Contributor
|
Based on the above, I've opened #2043 as alternative to this PR. |
Contributor
|
Closing this as #2043 has been merged instead. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes it compatible with protobuf 30+, a.k.a. 6, a.k.a. 6.30+