-
Notifications
You must be signed in to change notification settings - Fork 1
feat: update fork with 3.13 changes #21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Was only used in the console and might not be available in some embedding scenarios.
Verified them locally, but there is an issue with the Github workflow image that can hopefully be resolved later by using a full venv instead of relying on the system environment.
…nterface" This reverts commit 1dd36ae. # Conflicts: # src/runtime/Converter.cs # src/runtime/methodbinder.cs # src/runtime/typemanager.cs # src/testing/interfacetest.cs # tests/test_interface.py
This is used by ToPythonAs in this fork. In the upstream pythonnet, it is effectively always true
Member
Author
|
I also submitted pythonnet/pythonnet#2542 to fix their CI/CD - the job exclusion should have been done in this way. See 3b78bf1 |
Member
Author
|
Once merged, a new release should be done. This will open the door to projects depending on this fork |
SMoraisAnsys
approved these changes
Jan 8, 2025
SMoraisAnsys
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebasing fork and allowing for Python 3.13 builds