build: add tslint rule to enforce deletion targets #9881
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
Adds a tslint rule that will mark any deletion targets that are due to be deleted.
crisbeto
force-pushed
the
deletion-target-rule
branch
from
0f4521b to
5db7a07
Compare
CaerusKaru
added a commit
to angular/flex-layout
that referenced
this pull request
Feb 12, 2018
* Equivalent commit to angular/components#9881
CaerusKaru
added a commit
to angular/flex-layout
that referenced
this pull request
Feb 12, 2018
* Equivalent commit to angular/components#9881
jelbourn
approved these changes
Feb 13, 2018
Member
jelbourn
left a comment
jelbourn
left a comment
There was a problem hiding this comment.
LGTM
It would also be cool to ensure that anything @deprecated has a deletion target
jelbourn
added
pr: lgtm
action: merge
ThomasBurleson
pushed a commit
to angular/flex-layout
that referenced
this pull request
Feb 13, 2018
* Equivalent commit to angular/components#9881
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
Feb 13, 2018
Follow-up from angular#9881. Ensures that anything marked with `@deprecated` also has a `@deletion-target`.
jelbourn
pushed a commit
that referenced
this pull request
Feb 13, 2018
Follow-up from #9881. Ensures that anything marked with `@deprecated` also has a `@deletion-target`.
andrewseguin
pushed a commit
that referenced
this pull request
Feb 20, 2018
Adds a tslint rule that will mark any deletion targets that are due to be deleted.
andrewseguin
pushed a commit
that referenced
this pull request
Feb 20, 2018
Follow-up from #9881. Ensures that anything marked with `@deprecated` also has a `@deletion-target`.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a tslint rule that will mark any deletion targets that are due to be deleted.