build: enforce that deprecated APIs have a deletion target (#9931)

Follow-up from #9881. Ensures that anything marked with `@deprecated` also has a `@deletion-target`.

Author: crisbeto

src/lib/core/ripple/ripple-renderer.ts

@@ -16,7 +16,10 @@ export type RippleConfig = {
   persistent?: boolean;
   animation?: RippleAnimationConfig;
   terminateOnPointerUp?: boolean;
-  /** @deprecated Use the animation property instead. */
+  /**
+   * @deprecated Use the `animation` property instead.
+   * @deletion-target 7.0.0
+   */
   speedFactor?: number;
 };
 

tools/tslint-rules/deletionTargetRule.ts

@@ -14,18 +14,19 @@ export class Rule extends Lint.Rules.AbstractRule {
     return this.applyWithFunction(sourceFile, (ctx: Lint.WalkContext<any>) => {
       utils.forEachComment(ctx.sourceFile, (file, {pos, end}) => {
         const commentText = file.substring(pos, end);
-
-        if (commentText.indexOf('@deletion-target') === -1) {
-          return;
-        }
-
-        const version = commentText.match(/\d+\.\d+\.\d+/);
-
-        if (!version) {
-          ctx.addFailure(pos, end, '@deletion-target must have a version.');
-        } else if (this._hasExpired(packageVersion, version[0])) {
-          ctx.addFailure(pos, end, `Deletion target at ${version[0]} is due to be deleted. ` +
-                                   `Current version is ${packageVersion}.`);
+        const hasDeletionTarget = commentText.indexOf('@deletion-target') > -1;
+
+        if (!hasDeletionTarget && commentText.indexOf('@deprecated') > -1) {
+          ctx.addFailure(pos, end, '@deprecated marker has to have a @deletion-target.');
+        } if (hasDeletionTarget) {
+          const version = commentText.match(/\d+\.\d+\.\d+/);
+
+          if (!version) {
+            ctx.addFailure(pos, end, '@deletion-target must have a version.');
+          } else if (this._hasExpired(packageVersion, version[0])) {
+            ctx.addFailure(pos, end, `Deletion target at ${version[0]} is due to be deleted. ` +
+                                     `Current version is ${packageVersion}.`);
+          }
         }
       });
     });