Skip to content

build(material): add bazel rules for all components #8457

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 20, 2017
Merged

build(material): add bazel rules for all components #8457

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
anchor_1: &job_defaults
working_directory: ~/ng
docker:
- image: angular/ngcontainer:0.0.4
- image: angular/ngcontainer:0.0.7
Copy link
Contributor

@alexeagle alexeagle Dec 7, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

consider adding buildifier lint


# After checkout, rebase on top of master.
# Similar to travis behavior, but not quite the same.
Expand All @@ -24,6 +24,7 @@ version: 2
jobs:
build:
<<: *job_defaults
resource_class: large
steps:
- checkout:
<<: *post_checkout
Expand All @@ -32,9 +33,9 @@ jobs:

- run: bazel run @nodejs//:npm install
# For some reason, circleci needs the postinstall to be run explicitly.
# This may be unnecessary once ngcontainer uses nodejs 8
# This may be unnecessary once rules_nodejs uses nodejs 8
Copy link
Contributor

@alexeagle alexeagle Dec 7, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it does now, upgrade to 0.3.1

- run: bazel run @nodejs//:npm run postinstall
- run: bazel build src/cdk/...
- run: bazel build src/...
- save_cache:
key: material2-{{ .Branch }}-{{ checksum "package-lock.json" }}
paths:
Expand Down
3 changes: 2 additions & 1 deletion WORKSPACE
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ node_repositories(package_json = ["//:package.json"])
git_repository(
name = "io_bazel_rules_sass",
remote = "https://github.com/bazelbuild/rules_sass.git",
tag = "0.0.2",
tag = "0.0.3",
)

load("@io_bazel_rules_sass//sass:sass.bzl", "sass_repositories")
Expand All @@ -38,6 +38,7 @@ local_repository(
path = "node_modules/@angular/bazel",
)

# Add rxjs
local_repository(
name = "rxjs",
path = "node_modules/rxjs/src",
Expand Down
Loading