build(material): add bazel rules for all components #8457

jelbourn · 2017-11-15T20:09:45Z

Part of #8369
cc @devversion

The genrules for transforming the css output are unfortunate but should be able to be removed without a ton of effort.

jelbourn · 2017-11-16T00:47:45Z

Updated now with CircleCI config to build everything

alexeagle

comments apply to all BUILD.bazel files

alexeagle · 2017-11-16T00:48:54Z

.circleci/config.yml


      - run: bazel run @nodejs//:npm install
      # For some reason, circleci needs the postinstall to be run explicitly.
      # This may be unnecessary once ngcontainer uses nodejs 8


it's rules_nodejs that needs to switch, not ngcontainer

alexeagle · 2017-11-16T00:49:25Z

src/lib/autocomplete/BUILD.bazel

+package(default_visibility=["//visibility:public"])
+load("@angular//:index.bzl", "ng_module")
+load("@io_bazel_rules_sass//sass:sass.bzl", "sass_library")
+load("@io_bazel_rules_sass//sass:sass.bzl", "sass_binary")


you can load these two symbols in one load statement

alexeagle · 2017-11-16T00:49:54Z

src/lib/autocomplete/BUILD.bazel

+  tsconfig = ":tsconfig-build.json",
+)
+
+


buildozer is available externally, you could format all your BUILD files

Ack, I'll pursue that in a follow-up.

alexeagle · 2017-11-16T00:50:25Z

src/lib/autocomplete/BUILD.bazel

+  name = "autocomplete_css",
+  srcs = [":autocomplete_scss"],
+  outs = ["autocomplete.css"],
+  cmd = "cat $(locations :autocomplete_scss) > $@",


since you have a single src you can
cmd = "cp $< $@"

also, you do this enough that you might want to make a macro around sass_binary...

The sass_binary rule claims that it has multiple sources even though there is just one

alexeagle · 2017-11-16T00:50:44Z

src/lib/autocomplete/BUILD.bazel

+  deps = ["//src/lib/core:core_scss_lib"],
+)
+
+# TODO(jelbourn): remove this when sass_binary supports specifying an output filename and dir.


maybe file an issue for that on rules_sass?

Done bazelbuild/rules_sass#15

alexeagle · 2017-11-16T02:33:37Z

Even if srcs accepts an array I think $< still works if there happens to be one value?

…

On Wed, Nov 15, 2017, 5:22 PM Jeremy Elbourn ***@***.***> wrote: ***@***.**** commented on this pull request. ------------------------------ In .circleci/config.yml <#8457 (comment)>: > @@ -34,7 +34,7 @@ jobs: # For some reason, circleci needs the postinstall to be run explicitly. # This may be unnecessary once ngcontainer uses nodejs 8 Done ------------------------------ In src/lib/autocomplete/BUILD.bazel <#8457 (comment)>: > @@ -0,0 +1,40 @@ +package(default_visibility=["//visibility:public"]) ***@***.***//:index.bzl", "ng_module") ***@***.***_bazel_rules_sass//sass:sass.bzl", "sass_library") ***@***.***_bazel_rules_sass//sass:sass.bzl", "sass_binary") Done — You are receiving this because your review was requested. Reply to this email directly, view it on GitHub <#8457 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAC5I9RgWn7V-c_T7mzMoCHe1rBlSN1Rks5s245tgaJpZM4Qff7n> .

jelbourn · 2017-11-16T19:00:44Z

@alexeagle

ERROR: /usr/local/google/home/jelbourn/material2/src/lib/button/BUILD.bazel:39:9:
in cmd attribute of genrule rule //src/lib/button:button_css: variable '$<' : more than one input file

alexeagle

we should make sure tazel can re-generate all your BUILD files

alexeagle · 2017-12-07T23:53:11Z

.circleci/config.yml

  working_directory: ~/ng
  docker:
-    - image: angular/ngcontainer:0.0.4
+    - image: angular/ngcontainer:0.0.7


consider adding buildifier lint

alexeagle · 2017-12-07T23:53:26Z

.circleci/config.yml

      - run: bazel run @nodejs//:npm install
      # For some reason, circleci needs the postinstall to be run explicitly.
-      # This may be unnecessary once ngcontainer uses nodejs 8
+      # This may be unnecessary once rules_nodejs uses nodejs 8


it does now, upgrade to 0.3.1

alexeagle · 2017-12-07T23:53:39Z

.circleci/config.yml

      - run: bazel run @nodejs//:npm run postinstall
      - run: bazel build src/cdk/...
+      - run: bazel build src/lib/datepicker
+      - run: cat /root/.cache/bazel/_bazel_root/049ed6f058a98cba95753eee774cab7a/server/jvm.out


Yes, I'm in the middle of debugging now

Part of angular#8369

jelbourn · 2017-12-20T01:00:33Z

CircleCI issues are now resolved

josephperrott

LGTM

* Applies angular#8457 to divider

angular-automatic-lock-bot · 2019-09-08T15:02:42Z

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}

jelbourn added the pr: needs review label Nov 15, 2017

jelbourn requested a review from alexeagle November 15, 2017 20:09

jelbourn requested review from andrewseguin, crisbeto, devversion, josephperrott, kara, mmalerba and tinayuangao as code owners November 15, 2017 20:09

googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Nov 15, 2017

jelbourn force-pushed the bazel-material-rules branch 2 times, most recently from 18628c2 to c12ba80 Compare November 16, 2017 00:46

alexeagle approved these changes Nov 16, 2017

View reviewed changes

jelbourn mentioned this pull request Nov 16, 2017

Switch build to bazel #8369

Closed

17 tasks

jelbourn force-pushed the bazel-material-rules branch from c12ba80 to 56aea99 Compare November 16, 2017 01:17

jelbourn force-pushed the bazel-material-rules branch 2 times, most recently from 2a6516b to a640b83 Compare November 16, 2017 20:14

jelbourn force-pushed the bazel-material-rules branch 2 times, most recently from b795252 to 407eb09 Compare December 5, 2017 20:58

jelbourn added the pr: merge safe label Dec 6, 2017

jelbourn force-pushed the bazel-material-rules branch 3 times, most recently from ced197c to 34e3363 Compare December 7, 2017 23:39

alexeagle reviewed Dec 7, 2017

View reviewed changes

jelbourn force-pushed the bazel-material-rules branch 2 times, most recently from 8e17141 to 3ad8d6e Compare December 8, 2017 00:00

jelbourn force-pushed the bazel-material-rules branch from 3ad8d6e to 700250d Compare December 20, 2017 00:35

googlebot added cla: no PR author must sign Google's Contributor License Agreement: https://opensource.google.com/docs/cla and removed cla: yes PR author has agreed to Google's Contributor License Agreement labels Dec 20, 2017

build(material): add bazel rules for all components

e18736e

Part of angular#8369

jelbourn force-pushed the bazel-material-rules branch from 700250d to e18736e Compare December 20, 2017 00:49

angular deleted a comment from googlebot Dec 20, 2017

jelbourn added cla: yes PR author has agreed to Google's Contributor License Agreement and removed cla: no PR author must sign Google's Contributor License Agreement: https://opensource.google.com/docs/cla labels Dec 20, 2017

josephperrott approved these changes Dec 20, 2017

View reviewed changes

josephperrott added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Dec 20, 2017

josephperrott merged commit 444784b into angular:master Dec 20, 2017

CaerusKaru added a commit to CaerusKaru/components that referenced this pull request Dec 22, 2017

build: add bazel rules for divider

0e599ac

* Applies angular#8457 to divider

CaerusKaru mentioned this pull request Dec 22, 2017

build: add bazel rules for divider #9096

Merged

josephperrott pushed a commit to josephperrott/components that referenced this pull request Jan 2, 2018

build(material): add bazel rules for all components (angular#8457)

2bfec63

jelbourn deleted the bazel-material-rules branch April 2, 2018 22:31

angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019

build(material): add bazel rules for all components #8457

build(material): add bazel rules for all components #8457

Uh oh!

Conversation

jelbourn commented Nov 15, 2017

Uh oh!

jelbourn commented Nov 16, 2017

Uh oh!

alexeagle left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jelbourn Nov 16, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

alexeagle commented Nov 16, 2017 via email

Uh oh!

jelbourn commented Nov 16, 2017 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

alexeagle left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

jelbourn commented Dec 20, 2017

Uh oh!

josephperrott left a comment

Choose a reason for hiding this comment

Uh oh!

angular-automatic-lock-bot bot commented Sep 8, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

jelbourn Nov 16, 2017 •

edited

Loading

jelbourn commented Nov 16, 2017 •

edited

Loading