Skip to content

chore(dialog): switch to OnPush change detection #5422

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 28, 2017
Merged

chore(dialog): switch to OnPush change detection #5422

merged 1 commit into from
Jul 28, 2017

Conversation

@crisbeto
Copy link
Member

@crisbeto crisbeto commented Jun 29, 2017

Switches the dialog container to OnPush change detection.

Relates to #5035.

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jun 29, 2017
jelbourn
jelbourn approved these changes Jul 6, 2017
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker presubmit failures This PR has failures in Google's internal presubmit process and cannot be immediately merged and removed pr: needs review presubmit failures This PR has failures in Google's internal presubmit process and cannot be immediately merged labels Jul 6, 2017
@jelbourn jelbourn added the presubmit failures This PR has failures in Google's internal presubmit process and cannot be immediately merged label Jul 13, 2017
@jelbourn
Copy link
Member

jelbourn commented Jul 13, 2017

A google teams' screenshot test is showing that this change causes a dialog's content to not long have data binding resolved when its opened.

@crisbeto crisbeto force-pushed the 5035/dialog-onpush branch from 560ac71 to 80611d4 Compare July 13, 2017 17:51
@crisbeto
Copy link
Member Author

crisbeto commented Jul 13, 2017

I couldn't really repro it @jelbourn, but I've added a couple of markForCheck calls after the content is attached.

@crisbeto
chore(dialog): switch to OnPush change detection
da730df 
Switches the dialog container to `OnPush` change detection.

Relates to angular#5035.
@crisbeto crisbeto force-pushed the 5035/dialog-onpush branch from 80611d4 to da730df Compare July 13, 2017 17:52
@jelbourn
Copy link
Member

jelbourn commented Jul 13, 2017

I'll see if that fixes it before diving in further

@jelbourn
Copy link
Member

jelbourn commented Jul 14, 2017

Unfortunately that didn't change it. We'll need to investigate the app directly.

@mmalerba mmalerba mentioned this pull request Jul 18, 2017
Closed
@andrewseguin andrewseguin merged commit cf071c7 into angular:master Jul 28, 2017
andrewseguin added a commit to andrewseguin/components that referenced this pull request Jul 28, 2017
@andrewseguin
Revert "chore(dialog): switch to OnPush change detection (angular#5422)"
4c11128 
This reverts commit cf071c7.
andrewseguin added a commit to andrewseguin/components that referenced this pull request Jul 28, 2017
@andrewseguin
Revert "chore(dialog): switch to OnPush change detection (angular#5422)"
53a6cfd 
This reverts commit cf071c7.
andrewseguin added a commit that referenced this pull request Jul 28, 2017
@andrewseguin
revert(5422): chore(dialog): switch to OnPush change detection (#6123)
11975e6 
* fix(sidenav): animate sidenav on open/close changes

* Revert "chore(dialog): switch to OnPush change detection (#5422)"

This reverts commit cf071c7.
@crisbeto crisbeto mentioned this pull request Jul 28, 2017
Closed
@crisbeto crisbeto mentioned this pull request Aug 5, 2017
Merged
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Sep 6, 2019

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jelbourn jelbourn jelbourn approved these changes

Assignees

@jelbourn jelbourn

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement presubmit failures This PR has failures in Google's internal presubmit process and cannot be immediately merged

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@crisbeto @jelbourn @googlebot @andrewseguin