Skip to content

Conversation

@crisbeto
Copy link
Member

Switches the dialog container to OnPush change detection.

Relates to #5035.

Note: This is the same changeset from #5422 so we can continue investigating the sync failures.

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jul 28, 2017
@andrewseguin andrewseguin added the presubmit failures This PR has failures in Google's internal presubmit process and cannot be immediately merged label Jul 28, 2017
@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Jul 28, 2017
@jelbourn
Copy link
Member

Setting to merge-ready so it shows up on caretaker's radar

@crisbeto crisbeto closed this Aug 5, 2017
@crisbeto crisbeto force-pushed the 5035/dialog-onpush branch from da730df to 0850981 Compare August 5, 2017 07:28
@crisbeto
Copy link
Member Author

crisbeto commented Aug 5, 2017

@jelbourn for some reason rebasing this one ended up clearing all the changes, probably because of the revert commit on the previous PR. I'll re-re-open it with a brand new commit.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement presubmit failures This PR has failures in Google's internal presubmit process and cannot be immediately merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants