fix(cdk/overlay): disable backdrop animation when noop animations are enabled #24687
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… enabled Fixes that we weren't disabling the CDK backdrop transition when the noop animations module is used. This has caused test flakes in the past.
crisbeto
added
P2
devversion
approved these changes
Mar 29, 2022
andrewseguin
approved these changes
Mar 29, 2022
forsti0506
pushed a commit
to forsti0506/components
that referenced
this pull request
Apr 3, 2022
… enabled (angular#24687) Fixes that we weren't disabling the CDK backdrop transition when the noop animations module is used. This has caused test flakes in the past.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes that we weren't disabling the CDK backdrop transition when the noop animations module is used. This has caused test flakes in the past.