fix(overlay): disable all animations when using the NoopAnimationsModule

[crisbeto]

Disables the CSS-based animations in the overlay when using the NoopAnimationsModule.

Relates to #10590.

[mmalerba]

This introduces a dependency on @angular/animations that I don't think we want in the CDK

[crisbeto]

Isn’t the token technically in platform-browser? Also we’ve got the experimental/dialog which has a dependency on animations.

[mmalerba]

It is, though I assume @angular/platform-browser/animations would depend on @angular/animations? If it doesn't then maybe this is fine. @jelbourn might know more

[jelbourn]

I'm think we should just leave this one, since we haven't had any issues w/ overlay backdrop in particular

[crisbeto]

It’s something that came up in #10590 (comment).

[jelbourn]

I see; let's presubmit it then and see what happens

[jelbourn]

LGTM

[ngbot]

I see that you just added the pr: merge ready label, but the following checks are still failing:
     status "continuous-integration/travis-ci/pr" is failing

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

[mmalerba]

@jelbourn the presubmit will probably be fine (maybe have to change a BUILD rule or something) my concern was more, does this change cause @angular/cdk to depend on @angular/animations, and if so is that a problem?

[jelbourn]

Ah, I was just thinking about Google, but yeah, it would technically be a breaking change if there's a new peerDep for @angular/cdk, even though the vast majority of people will have the right packages installed already

[crisbeto]

The question is whether it’s actually a new peerDep. The new import is from platform-browser/animations, rather than animations.

[jelbourn]

cdk is currently

  "peerDependencies": {
    "@angular/core": "0.0.0-NG",
    "@angular/common": "0.0.0-NG"
  },

[mmalerba]

I asked Matias and he said @angular/platform-browser/animations does depend on @angular/animations. I also put together a stackblitz that shows this: https://stackblitz.com/edit/angular-material2-issue-gul2bw?file=app/app.component.ts

[ngbot]

Hi @crisbeto! This PR has merge conflicts due to recent upstream merges.
Please help to unblock it by resolving these conflicts. Thanks!

[pfeigl]

Has there been any decision whether this breaking change is going into cdk? It's easy enough for now using a .cdk-overlay-backdrop { transition: none; } but ugh ... Looking forward to be able to disable transiations in overlays the right way 👍

[mmalerba]

I think we still want to do this, just at a major release, @jelbourn correct me if I'm wrong

[crisbeto]

Closing in favor of #24687.

[angular-automatic-lock-bot]

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

_{This action has been performed automatically by a bot.}