Skip to content

refactor: use officially supported strict_templates attribute on ng_module() and remove local workaround #23677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

refactor: use officially supported strict_templates attribute on ng_module() and remove local workaround #23677

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions tools/defaults.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,6 +86,7 @@ def ng_module(
tsconfig = None,
flat_module_out_file = None,
testonly = False,
strict_templates = True,
**kwargs):
if not tsconfig:
tsconfig = _getDefaultTsConfig(testonly)
Expand Down Expand Up @@ -139,6 +140,7 @@ def ng_module(
deps = local_deps,
tsconfig = tsconfig,
testonly = testonly,
strict_templates = strict_templates,
**kwargs
)

Expand Down
6 changes: 0 additions & 6 deletions tools/postinstall/apply-patches.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,12 +110,6 @@ function applyPatches() {
// Workaround for: https://github.com/bazelbuild/rules_nodejs/issues/1208.
applyPatch(path.join(__dirname, './manifest_externs_hermeticity.patch'));

// Workaround for https://github.com/angular/angular/issues/33452:
searchAndReplace(
/angular_compiler_options = {/, `$&
"strictTemplates": True,`,
'node_modules/@angular/bazel/src/ng_module.bzl');

// More info in https://github.com/angular/angular/pull/33786
shelljs.rm('-rf', [
'node_modules/rxjs/add/',
Expand Down