Skip to content

Conversation

@dgp1130
Copy link
Contributor

@dgp1130 dgp1130 commented Oct 1, 2021

Refs: angular/angular#33452.

This workaround is no longer necessary since ng_module() actually supports strict templates now (see angular/angular#43582).

Creating this PR as a draft right now as it is blocked on components upgrading to @angular/[email protected] or later.

…g_module()` and remove local workaround

Refs: angular/angular#33452.

This workaround is no longer necessary since `ng_module()` actually supports strict templates now (see angular/angular#43582).
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Oct 1, 2021
@dgp1130 dgp1130 added the target: major This PR is targeted for the next major release label Oct 1, 2021
@dgp1130
Copy link
Contributor Author

dgp1130 commented Oct 7, 2021

The desired change here got included in #23689. The strict templates patch is removed and ng_module() now sets strict_templates = True by default, using supported features from @angular/bazel.

Nothing more to do here.

@dgp1130 dgp1130 closed this Oct 7, 2021
@dgp1130 dgp1130 deleted the strict-templates branch October 7, 2021 22:14
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Nov 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes PR author has agreed to Google's Contributor License Agreement target: major This PR is targeted for the next major release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant