Skip to content

fix(cdk/a11y): error on firefox #23395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 18, 2021
Merged

fix(cdk/a11y): error on firefox #23395

merged 1 commit into from
Aug 18, 2021

Conversation

@crisbeto
Copy link
Member

@crisbeto crisbeto commented Aug 18, 2021

We seem to hitting an error on Firefox when calling closest inside a unit test. These changes add a null check to work around the issue.

@crisbeto
fix(cdk/a11y): error on firefox
eb0b15e 
We seem to hitting an error on Firefox when calling `closest` inside a unit test. These changes add a null check to work around the issue.
@crisbeto crisbeto added P2 The issue is important to a large percentage of users, with a workaround merge safe target: patch This PR is targeted for the next patch release labels Aug 18, 2021
@crisbeto crisbeto requested a review from jelbourn as a code owner August 18, 2021 15:56
@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Aug 18, 2021
@devversion devversion mentioned this pull request Aug 18, 2021
Merged
wagnermaciel
wagnermaciel approved these changes Aug 18, 2021
View reviewed changes
Copy link
Contributor

@wagnermaciel wagnermaciel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wagnermaciel wagnermaciel added action: merge The PR is ready for merge by the caretaker target: major This PR is targeted for the next major release and removed target: patch This PR is targeted for the next patch release labels Aug 18, 2021
@wagnermaciel wagnermaciel merged commit b25283c into angular:master Aug 18, 2021
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Sep 18, 2021

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@wagnermaciel wagnermaciel wagnermaciel approved these changes

@devversion devversion Awaiting requested review from devversion

@jelbourn jelbourn Awaiting requested review from jelbourn

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement P2 The issue is important to a large percentage of users, with a workaround target: major This PR is targeted for the next major release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@crisbeto @wagnermaciel