refactor(cdk/testing): switch to event constructor for creating fake events #23394
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
devversion
force-pushed
the
refactor/switch-to-event-constructors-for-fake-events
branch
4 times, most recently
from
d9a7880 to
ef01eb0
Compare
Member
Author
|
Test failures for cdk/a11y seem to be unrelated. see #23395 |
devversion
added
P3
…events Switches from the legacy `init<..>Event` calls to the Event constructors given that IE11 no longer is supported.
devversion
force-pushed
the
refactor/switch-to-event-constructors-for-fake-events
branch
from
ef01eb0 to
b014380
Compare
devversion
added
action: merge
The fake `TouchEvent` being created by test harnesses for the TestBed harness environment currently set an id for a `Touch` of the fake event. The `Touch` currently incorrectly sets the unique touch id to a field named `id`, while it should be `identifier`.
devversion
force-pushed
the
refactor/switch-to-event-constructors-for-fake-events
branch
from
b014380 to
366c303
Compare
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switches from the legacy
init<..>Eventcalls to the Event constructorsgiven that IE11 no longer is supported.