build: ampersand selector lint rule not catching some cases #22974
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added
P3
google-cla
bot
added
the
cla: yes
crisbeto
force-pushed
the
ampersand-selector-lint
branch
from
b3c0b37 to
e764ba6
Compare
devversion
reviewed
Jun 15, 2021
crisbeto
force-pushed
the
ampersand-selector-lint
branch
from
e764ba6 to
51ff6ab
Compare
devversion
approved these changes
Jun 15, 2021
Member
devversion
left a comment
devversion
left a comment
There was a problem hiding this comment.
LGTM. One minor comment that might simplify this a little more
I noticed this while working on something else. The ampersand selector mixin looks for one `&` instance and then gives up, but there might be other ampersands inside the same selector which are invalid. These changes update the logic to be a bit more robust and remove the limitation where failures weren't reported on private mixins.
crisbeto
force-pushed
the
ampersand-selector-lint
branch
from
51ff6ab to
16f0a67
Compare
wagnermaciel
pushed a commit
that referenced
this pull request
Jun 16, 2021
I noticed this while working on something else. The ampersand selector mixin looks for one `&` instance and then gives up, but there might be other ampersands inside the same selector which are invalid. These changes update the logic to be a bit more robust and remove the limitation where failures weren't reported on private mixins. (cherry picked from commit d97e5ae)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed this while working on something else. The ampersand selector mixin looks for one
&instance and then gives up, but there might be other ampersands inside the same selector which are invalid.These changes update the logic to be a bit more robust and remove the limitation where failures weren't reported on private mixins.