build: ampersand selector lint rule not catching some cases

I noticed this while working on something else. The ampersand selector mixin looks for one `&` instance and then gives up, but there might be other ampersands inside the same selector which are invalid.

These changes update the logic to be a bit more robust and remove the limitation where failures weren't reported on private mixins.

Author: crisbeto

src/material/badge/_badge-theme.scss

@@ -18,6 +18,8 @@ $large-size: $default-size + 6;
 
 // Mixin for building offset given different sizes
 @mixin _badge-size($size) {
+  // This mixin isn't used in the context of a theme so we can disable the ampersand check.
+  // stylelint-disable material/no-ampersand-beyond-selector-start
   .mat-badge-content {
     width: $size;
     height: $size;
@@ -89,6 +91,7 @@ $large-size: $default-size + 6;
       }
     }
   }
+  // stylelint-enable
 }
 
 @mixin color($config-or-theme) {

tools/stylelint/no-ampersand-beyond-selector-start.ts

@@ -1,6 +1,5 @@
 import {createPlugin, utils} from 'stylelint';
 import {basename} from 'path';
-import {Node} from './stylelint-postcss-types';
 
 const isStandardSyntaxRule = require('stylelint/lib/utils/isStandardSyntaxRule');
 const isStandardSyntaxSelector = require('stylelint/lib/utils/isStandardSyntaxSelector');
@@ -37,43 +36,38 @@ const plugin = createPlugin(ruleName, (isEnabled: boolean, _options?) => {
     }
 
     root.walkRules(rule => {
-      if (
-        rule.parent.type === 'rule' &&
-        isStandardSyntaxRule(rule) &&
-        isStandardSyntaxSelector(rule.selector) &&
-        // Using the ampersand at the beginning is fine, anything else can cause issues in themes.
-        rule.selector.indexOf('&') > 0) {
-
-        const mixinName = getClosestMixinName(rule);
-
-        // Skip rules inside private mixins.
-        if (!mixinName || !mixinName.startsWith('_')) {
-          utils.report({
-            result,
-            ruleName,
-            message: messages.expected(),
-            node: rule
-          });
-        }
+      if (rule.parent.type === 'rule' &&
+          isStandardSyntaxRule(rule) &&
+          isStandardSyntaxSelector(rule.selector) &&
+          hasInvalidAmpersandUsage(rule.selector)) {
+        utils.report({
+          result,
+          ruleName,
+          message: messages.expected(),
+          node: rule
+        });
       }
     });
   };
+});
+
+function hasInvalidAmpersandUsage(selector: string): boolean {
+  const parts = selector.split(',').map(part => part.trim());
 
-  /** Walks up the AST and finds the name of the closest mixin. */
-  function getClosestMixinName(node: Node): string | undefined {
-    let parent = node.parent;
+  for (const part of parts) {
+    let index = part.indexOf('&');
 
-    while (parent) {
-      if (parent.type === 'atrule' && parent.name === 'mixin') {
-        return parent.params;
+    while (index > -1) {
+      if (index > 0) {
+        return true;
       }
 
-      parent = parent.parent;
+      index = part.indexOf('&', index + 1);
     }
-
-    return undefined;
   }
-});
+
+  return false;
+}
 
 plugin.ruleName = ruleName;
 plugin.messages = messages;