Skip to content

test(material/bottom-sheet): refactor variable type to const in bottom-sheet component unit tests #22895

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 16, 2021
Merged

test(material/bottom-sheet): refactor variable type to const in bottom-sheet component unit tests #22895

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions src/material/bottom-sheet/bottom-sheet.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,7 +189,7 @@ describe('MatBottomSheet', () => {

viewContainerFixture.detectChanges();

let backdrop = overlayContainerElement.querySelector('.cdk-overlay-backdrop') as HTMLElement;
const backdrop = overlayContainerElement.querySelector('.cdk-overlay-backdrop') as HTMLElement;

backdrop.click();
viewContainerFixture.detectChanges();
Expand Down Expand Up @@ -252,7 +252,7 @@ describe('MatBottomSheet', () => {

viewContainerFixture.detectChanges();

let overlayPane = overlayContainerElement.querySelector('.cdk-global-overlay-wrapper')!;
const overlayPane = overlayContainerElement.querySelector('.cdk-global-overlay-wrapper')!;

expect(overlayPane.getAttribute('dir')).toBe('rtl');
});
Expand Down Expand Up @@ -320,7 +320,7 @@ describe('MatBottomSheet', () => {
}));

it('should open a new bottom sheet after dismissing a previous sheet', fakeAsync(() => {
let config: MatBottomSheetConfig = {viewContainerRef: testViewContainerRef};
const config: MatBottomSheetConfig = {viewContainerRef: testViewContainerRef};
let bottomSheetRef: MatBottomSheetRef<any> = bottomSheet.open(PizzaMsg, config);

viewContainerFixture.detectChanges();
Expand Down Expand Up @@ -495,7 +495,8 @@ describe('MatBottomSheet', () => {

viewContainerFixture.detectChanges();

let backdrop = overlayContainerElement.querySelector('.cdk-overlay-backdrop') as HTMLElement;
const backdrop =
overlayContainerElement.querySelector('.cdk-overlay-backdrop') as HTMLElement;
backdrop.click();
viewContainerFixture.detectChanges();
flush();
Expand All @@ -518,14 +519,15 @@ describe('MatBottomSheet', () => {
}));

it('should allow for the disableClose option to be updated while open', fakeAsync(() => {
let bottomSheetRef = bottomSheet.open(PizzaMsg, {
const bottomSheetRef = bottomSheet.open(PizzaMsg, {
disableClose: true,
viewContainerRef: testViewContainerRef
});

viewContainerFixture.detectChanges();

let backdrop = overlayContainerElement.querySelector('.cdk-overlay-backdrop') as HTMLElement;
const backdrop =
overlayContainerElement.querySelector('.cdk-overlay-backdrop') as HTMLElement;
backdrop.click();

expect(overlayContainerElement.querySelector('mat-bottom-sheet-container')).toBeTruthy();
Expand Down