Skip to content

test(material/bottom-sheet): refactor variable type to const in bottom-sheet component unit tests #22895

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 16, 2021
Merged

test(material/bottom-sheet): refactor variable type to const in bottom-sheet component unit tests #22895

merged 1 commit into from
Jun 16, 2021

Conversation

@nitinmalave
Copy link
Contributor

@nitinmalave nitinmalave commented Jun 4, 2021

Opening this PR as it is required to:

  • Refactor variables in bottom-sheet component unit tests to have constant type instead of let as this variables are not getting re-initialize during the test life-time.
  • All tests within a spec should be consistent with all other tests in repo.

@google-cla google-cla bot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jun 4, 2021
@nitinmalave nitinmalave force-pushed the refactor-bottom-sheet-component-unit-tests branch from 4498851 to f83dfb3 Compare June 4, 2021 20:10
@nitinmalave nitinmalave changed the title refactor(material/bottom-sheet): refactor variable type to const in bottom-sheet component unit tests test(material/bottom-sheet): refactor variable type to const in bottom-sheet component unit tests Jun 7, 2021
@nitinmalave
test(material/bottom-sheet): refactor variable type to const in botto…
d4ffdb7 
…m-sheet component unit tests

style(material/bottom-sheet): fix tslint max-line-length exceeds issue in ci build
@nitinmalave nitinmalave force-pushed the refactor-bottom-sheet-component-unit-tests branch from f83dfb3 to d4ffdb7 Compare June 7, 2021 14:15
@nitinmalave
Copy link
Contributor Author

nitinmalave commented Jun 11, 2021

Hi @crisbeto, please take a look at this PR as well which i did open for similar refactoring in different component.

crisbeto
crisbeto approved these changes Jun 14, 2021
View reviewed changes
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crisbeto crisbeto added action: merge The PR is ready for merge by the caretaker merge safe target: patch This PR is targeted for the next patch release labels Jun 14, 2021
@wagnermaciel wagnermaciel merged commit b57b686 into angular:master Jun 16, 2021
wagnermaciel pushed a commit that referenced this pull request Jun 16, 2021
@nitinmalave @wagnermaciel
test(material/bottom-sheet): refactor variable type to const in botto…
90f3316 
…m-sheet component unit tests (#22895)

style(material/bottom-sheet): fix tslint max-line-length exceeds issue in ci build

(cherry picked from commit b57b686)
@nitinmalave nitinmalave deleted the refactor-bottom-sheet-component-unit-tests branch June 16, 2021 13:00
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Jul 17, 2021

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Jul 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@crisbeto crisbeto crisbeto approved these changes

@jelbourn jelbourn Awaiting requested review from jelbourn

Assignees

No one assigned

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@nitinmalave @crisbeto @wagnermaciel