fix(material-experimental): unit tests getting wrong root element and add API for getting property value #16706
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
crisbeto
added
P2
googlebot
added
the
cla: yes
devversion
approved these changes
Aug 7, 2019
Member
devversion
left a comment
devversion
left a comment
There was a problem hiding this comment.
The propertyValue method is similar to what I did in the input harness (ae96075) but it's better to have it in a separate PR. LGTM
devversion
added
pr: lgtm
action: merge
This comment has been minimized.
This comment has been minimized.
crisbeto
force-pushed
the
harness-misc-fixes
branch
2 times, most recently
from
7889ec7 to
06b0d0a
Compare
mmalerba
reviewed
Aug 8, 2019
jelbourn
reviewed
Aug 9, 2019
Contributor
|
re-apply merge ready after comments are resolved |
Member
|
Commenting here for posterity: decided in the team meeting to do separate methods for attributes and properties with no fallbacks |
crisbeto
force-pushed
the
harness-misc-fixes
branch
4 times, most recently
from
2c2757f to
8dd52a8
Compare
mmalerba
reviewed
Aug 22, 2019
mmalerba
reviewed
Aug 22, 2019
crisbeto
force-pushed
the
harness-misc-fixes
branch
2 times, most recently
from
0cb3c82 to
b12ed29
Compare
… add API for getting property value Based on the discussion in angular#16697 (comment), these changes fix a couple of things that I ran into while doing the `mat-autocomplete` test harness in angular#16620. * Fixes querying for elements outside the harness not working, because the wrong root node was set. * Adds an API to retrieve the value of a property on a DOM node.
crisbeto
force-pushed
the
harness-misc-fixes
branch
from
b12ed29 to
adb5881
Compare
Member
Author
|
@mmalerba all the feedback has been addressed. |
mmalerba
approved these changes
Aug 22, 2019
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on the discussion in #16697 (comment), these changes fix a couple of things that I ran into while doing the
mat-autocompletetest harness in #16620.Note: marking as P2, because the issue with the root node is something that'll come up every time we write a harness for an overlay-based component.