feat(material-experimental): add test harness for snack-bar #16697
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devversion
added
pr: merge safe
target: patch
googlebot
added
the
cla: yes
devversion
commented
Aug 6, 2019
src/cdk-experimental/testing/testbed/testbed-harness-environment.ts
Outdated
Show resolved
Hide resolved
devversion
force-pushed
the
feat/test-harness-mdc-snack-bar
branch
from
6827a07 to
b95e59d
Compare
devversion
changed the title
devversion
force-pushed
the
feat/test-harness-mdc-snack-bar
branch
from
b95e59d to
1ebb813
Compare
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
Aug 7, 2019
… add API for getting property value Based on the discussion in angular#16697 (comment), these changes fix a couple of things that I ran into while doing the `mat-autocomplete` test harness in angular#16620. * Fixes querying for elements outside the harness not working, because the wrong root node was set. * Adds an API to retrieve the value of a property on a DOM node.
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
Aug 7, 2019
… add API for getting property value Based on the discussion in angular#16697 (comment), these changes fix a couple of things that I ran into while doing the `mat-autocomplete` test harness in angular#16620. * Fixes querying for elements outside the harness not working, because the wrong root node was set. * Adds an API to retrieve the value of a property on a DOM node.
devversion
pushed a commit
to devversion/material2
that referenced
this pull request
Aug 7, 2019
… add API for getting property value Based on the discussion in angular#16697 (comment), these changes fix a couple of things that I ran into while doing the `mat-autocomplete` test harness in angular#16620. * Fixes querying for elements outside the harness not working, because the wrong root node was set. * Adds an API to retrieve the value of a property on a DOM node.
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
Aug 7, 2019
… add API for getting property value Based on the discussion in angular#16697 (comment), these changes fix a couple of things that I ran into while doing the `mat-autocomplete` test harness in angular#16620. * Fixes querying for elements outside the harness not working, because the wrong root node was set. * Adds an API to retrieve the value of a property on a DOM node.
devversion
pushed a commit
to devversion/material2
that referenced
this pull request
Aug 7, 2019
… add API for getting property value Based on the discussion in angular#16697 (comment), these changes fix a couple of things that I ran into while doing the `mat-autocomplete` test harness in angular#16620. * Fixes querying for elements outside the harness not working, because the wrong root node was set. * Adds an API to retrieve the value of a property on a DOM node.
devversion
force-pushed
the
feat/test-harness-mdc-snack-bar
branch
from
1ebb813 to
54e554b
Compare
devversion
pushed a commit
to devversion/material2
that referenced
this pull request
Aug 7, 2019
… add API for getting property value Based on the discussion in angular#16697 (comment), these changes fix a couple of things that I ran into while doing the `mat-autocomplete` test harness in angular#16620. * Fixes querying for elements outside the harness not working, because the wrong root node was set. * Adds an API to retrieve the value of a property on a DOM node.
This comment has been minimized.
This comment has been minimized.
googlebot
added
cla: no
devversion
force-pushed
the
feat/test-harness-mdc-snack-bar
branch
from
54e554b to
fb0a398
Compare
This comment has been minimized.
This comment has been minimized.
googlebot
added
cla: yes
devversion
pushed a commit
to devversion/material2
that referenced
this pull request
Aug 15, 2019
… add API for getting property value Based on the discussion in angular#16697 (comment), these changes fix a couple of things that I ran into while doing the `mat-autocomplete` test harness in angular#16620. * Fixes querying for elements outside the harness not working, because the wrong root node was set. * Adds an API to retrieve the value of a property on a DOM node.
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
Aug 22, 2019
… add API for getting property value Based on the discussion in angular#16697 (comment), these changes fix a couple of things that I ran into while doing the `mat-autocomplete` test harness in angular#16620. * Fixes querying for elements outside the harness not working, because the wrong root node was set. * Adds an API to retrieve the value of a property on a DOM node.
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
Aug 22, 2019
… add API for getting property value Based on the discussion in angular#16697 (comment), these changes fix a couple of things that I ran into while doing the `mat-autocomplete` test harness in angular#16620. * Fixes querying for elements outside the harness not working, because the wrong root node was set. * Adds an API to retrieve the value of a property on a DOM node.
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
Aug 22, 2019
… add API for getting property value Based on the discussion in angular#16697 (comment), these changes fix a couple of things that I ran into while doing the `mat-autocomplete` test harness in angular#16620. * Fixes querying for elements outside the harness not working, because the wrong root node was set. * Adds an API to retrieve the value of a property on a DOM node.
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
Aug 22, 2019
… add API for getting property value Based on the discussion in angular#16697 (comment), these changes fix a couple of things that I ran into while doing the `mat-autocomplete` test harness in angular#16620. * Fixes querying for elements outside the harness not working, because the wrong root node was set. * Adds an API to retrieve the value of a property on a DOM node.
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
Aug 22, 2019
… add API for getting property value Based on the discussion in angular#16697 (comment), these changes fix a couple of things that I ran into while doing the `mat-autocomplete` test harness in angular#16620. * Fixes querying for elements outside the harness not working, because the wrong root node was set. * Adds an API to retrieve the value of a property on a DOM node.
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
Aug 22, 2019
… add API for getting property value Based on the discussion in angular#16697 (comment), these changes fix a couple of things that I ran into while doing the `mat-autocomplete` test harness in angular#16620. * Fixes querying for elements outside the harness not working, because the wrong root node was set. * Adds an API to retrieve the value of a property on a DOM node.
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
Aug 22, 2019
… add API for getting property value Based on the discussion in angular#16697 (comment), these changes fix a couple of things that I ran into while doing the `mat-autocomplete` test harness in angular#16620. * Fixes querying for elements outside the harness not working, because the wrong root node was set. * Adds an API to retrieve the value of a property on a DOM node.
mmalerba
pushed a commit
that referenced
this pull request
Aug 22, 2019
… add API for getting property value (#16706) Based on the discussion in #16697 (comment), these changes fix a couple of things that I ran into while doing the `mat-autocomplete` test harness in #16620. * Fixes querying for elements outside the harness not working, because the wrong root node was set. * Adds an API to retrieve the value of a property on a DOM node.
devversion
force-pushed
the
feat/test-harness-mdc-snack-bar
branch
from
fb0a398 to
44d4f44
Compare
devversion
added a commit
to devversion/material2
that referenced
this pull request
Aug 28, 2019
…nment Adds a new method that can be used by harness consumers to load a harness through `HarnessLoader` from the document root. This is helpful for harnesses which need to match elements outside of testbed fixtures (e.g. snack-bars, overlays etc.). Needed for angular#16697 and angular#16709.
devversion
added a commit
to devversion/material2
that referenced
this pull request
Aug 29, 2019
…s environment Adds a new method that can be used by harness consumers to load a harness through `HarnessLoader` from the document root. This is helpful for harnesses which need to match elements outside of testbed fixtures (e.g. snack-bars, overlays etc.). Needed for angular#16697 and angular#16709.
devversion
added a commit
to devversion/material2
that referenced
this pull request
Aug 29, 2019
…s environment Adds a new method that can be used by harness consumers to load a harness through `HarnessLoader` from the document root. This is helpful for harnesses which need to match elements outside of testbed fixtures (e.g. snack-bars, overlays etc.). Needed for angular#16697 and angular#16709.
devversion
added a commit
to devversion/material2
that referenced
this pull request
Sep 5, 2019
…s environment Adds a new method that can be used by harness consumers to load a harness through `HarnessLoader` from the document root. This is helpful for harnesses which need to match elements outside of testbed fixtures (e.g. snack-bars, overlays etc.). Needed for angular#16697 and angular#16709.
devversion
added a commit
to devversion/material2
that referenced
this pull request
Sep 6, 2019
…s environment Adds a new method that can be used by harness consumers to load a harness through `HarnessLoader` from the document root. This is helpful for harnesses which need to match elements outside of testbed fixtures (e.g. snack-bars, overlays etc.). Needed for angular#16697 and angular#16709.
devversion
force-pushed
the
feat/test-harness-mdc-snack-bar
branch
from
44d4f44 to
3e9db90
Compare
devversion
added a commit
to devversion/material2
that referenced
this pull request
Sep 6, 2019
…s environment Adds a new method that can be used by harness consumers to load a harness through `HarnessLoader` from the document root. This is helpful for harnesses which need to match elements outside of testbed fixtures (e.g. snack-bars, overlays etc.). Needed for angular#16697 and angular#16709.
devversion
added a commit
to devversion/material2
that referenced
this pull request
Sep 17, 2019
…s environment Adds a new method that can be used by harness consumers to load a harness through `HarnessLoader` from the document root. This is helpful for harnesses which need to match elements outside of testbed fixtures (e.g. snack-bars, overlays etc.). Needed for angular#16697 and angular#16709.
devversion
added a commit
to devversion/material2
that referenced
this pull request
Sep 17, 2019
…s environment Adds a new method that can be used by harness consumers to load a harness through `HarnessLoader` from the document root. This is helpful for harnesses which need to match elements outside of testbed fixtures (e.g. snack-bars, overlays etc.). Needed for angular#16697 and angular#16709.
devversion
added a commit
to devversion/material2
that referenced
this pull request
Sep 17, 2019
…s environment Adds a new method that can be used by harness consumers to load a harness through `HarnessLoader` from the document root. This is helpful for harnesses which need to match elements outside of testbed fixtures (e.g. snack-bars, overlays etc.). Needed for angular#16697 and angular#16709.
devversion
force-pushed
the
feat/test-harness-mdc-snack-bar
branch
from
3e9db90 to
3899191
Compare
jelbourn
pushed a commit
to jelbourn/components
that referenced
this pull request
Sep 24, 2019
…s environment (angular#16903) Adds a new method that can be used by harness consumers to load a harness through `HarnessLoader` from the document root. This is helpful for harnesses which need to match elements outside of testbed fixtures (e.g. snack-bars, overlays etc.). Needed for angular#16697 and angular#16709. (cherry picked from commit 3765433)
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.