Skip to content

Conversation

@crisbeto
Copy link
Member

In 8.0 the runSchematic method is marked as deprecated. These changes switch all the usages to runSchematicAsync.

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label May 29, 2019
In 8.0 the `runSchematic` method is marked as deprecated. These changes switch all the usages to `runSchematicAsync`.
@crisbeto crisbeto force-pushed the schematic-test-migration branch from 8bd8718 to a6759ae Compare May 29, 2019 14:43
@crisbeto crisbeto added pr: merge safe target: patch This PR is targeted for the next patch release labels May 29, 2019
@crisbeto crisbeto marked this pull request as ready for review May 29, 2019 15:08
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels May 29, 2019
crisbeto added a commit to crisbeto/angular that referenced this pull request May 30, 2019
Switches all of the tests away from the `runSchematic` method which was deprecated in 8.0 (see angular/angular-cli#14412). Along the same lines as angular/components#16150.
mhevery pushed a commit to angular/angular that referenced this pull request May 31, 2019
Switches all of the tests away from the `runSchematic` method which was deprecated in 8.0 (see angular/angular-cli#14412). Along the same lines as angular/components#16150.

PR Close #30747
@andrewseguin andrewseguin merged commit b261afa into angular:master May 31, 2019
josephperrott pushed a commit that referenced this pull request Jun 10, 2019
In 8.0 the `runSchematic` method is marked as deprecated. These changes switch all the usages to `runSchematicAsync`.
RudolfFrederiksen pushed a commit to RudolfFrederiksen/material2 that referenced this pull request Jun 21, 2019
In 8.0 the `runSchematic` method is marked as deprecated. These changes switch all the usages to `runSchematicAsync`.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 10, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants