fix(@angular-devkit/schematics): deprecate synchronous testing methods #14412
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alan-agius4
reviewed
May 13, 2019
All schematics can potentially be async. The synchronous test method variants (`runSchematic`/`runExternalSchematic`) will fail if the schematic, any of its rules, or any schematic it calls are async.
clydin
force-pushed
the
deprecate-schematics-testing
branch
from
1a80072 to
eb488f2
Compare
alan-agius4
approved these changes
May 15, 2019
crisbeto
added a commit
to crisbeto/angular
that referenced
this pull request
May 30, 2019
Switches all of the tests away from the `runSchematic` method which was deprecated in 8.0 (see angular/angular-cli#14412). Along the same lines as angular/components#16150.
mhevery
pushed a commit
to angular/angular
that referenced
this pull request
May 31, 2019
Switches all of the tests away from the `runSchematic` method which was deprecated in 8.0 (see angular/angular-cli#14412). Along the same lines as angular/components#16150. PR Close #30747
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All schematics can potentially be async. The synchronous test method variants (
runSchematic/runExternalSchematic) will fail if the schematic, any of its rules, or any schematic it calls are async.