Skip to content

Conversation

@andrewseguin
Copy link
Contributor

This was merged and reverted: #10743, #11017

Forgot that this is broken until rc.6 due to an Angular issue: angular/angular#23440

Can be merged after we update to rc.6


Adds all examples to an example page on the demo app.

2msgfpxfp3x

@andrewseguin andrewseguin requested a review from jelbourn April 26, 2018 05:09
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Apr 26, 2018
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Apr 26, 2018
@ngbot
Copy link

ngbot bot commented Apr 26, 2018

I see that you just added the pr: merge ready label, but the following checks are still failing:
    failure missing required label: "release: *"
    failure status "continuous-integration/travis-ci/pr" is failing
    pending 2 pending code reviews

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@andrewseguin andrewseguin merged commit 1ee9c5f into angular:master Apr 28, 2018
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants