Skip to content

Conversation

@andrewseguin
Copy link
Contributor

@andrewseguin andrewseguin commented Apr 6, 2018

Includes changes in PR #10739

Adds all examples to an example page on the demo app.

2msgfpxfp3x

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Apr 6, 2018
@andrewseguin andrewseguin added pr: needs review target: patch This PR is targeted for the next patch release labels Apr 6, 2018
@josephperrott josephperrott removed their request for review April 9, 2018 15:31
@jelbourn
Copy link
Member

I'm concerned this will make the demo-app super slow.

Does it make the demo app super slow?

@andrewseguin
Copy link
Contributor Author

Based on a rough experiment, I found that it took the following number of seconds to refresh the demo app and open the main sidenav:

On master: 16.0s, 15.9s, 16.0s
With this PR: 16.8s, 16.6s

So maybe half a second longer. Then again I might have grown a tired finger pushing the start button my stopwatch =)

Overall, no real perceptible difference.

Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

import {TableDemoModule} from '../table/table-demo-module';
import {
Counter, FoggyTabContent, RainyTabContent, SunnyTabContent, TabsDemo
Counter,FoggyTabContent, RainyTabContent, SunnyTabContent, TabsDemo
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Formatting

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Apr 25, 2018
@ngbot
Copy link

ngbot bot commented Apr 25, 2018

I see that you just added the pr: merge ready label, but the following checks are still failing:
    failure status "continuous-integration/travis-ci/pr" is failing
    pending 3 pending code reviews

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@andrewseguin andrewseguin merged commit 68b1f2a into angular:master Apr 26, 2018
andrewseguin added a commit that referenced this pull request Apr 26, 2018
andrewseguin added a commit that referenced this pull request Apr 26, 2018
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants