refactor(overlay): remove 6.0.0 deletion targets #10161
Merged
+28
−124
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
Member
|
Same comment about breaking change format |
Removes all of the APIs that were marked for deletion in 6.0.0 from the `cdk/overlay` entry point. BREAKING CHANGES: * `ConnectedOverlayDirective` which was deprecated in 5.0.0 has been removed. Use `CdkConnectedOverlay` instead. * `OverlayOrigin` which was deprecated in 5.0.0 has been removed. Use `CdkOverlayOrigin` instead. * `hasBackdrop` which was deprecated in 5.0.0 has been removed. Use `cdkConnectedOverlayHasBackdrop` instead. * `open` which was deprecated in 5.0.0 has been removed. Use `cdkConnectedOverlayOpen` instead. * `scrollStrategy` which was deprecated in 5.0.0 has been removed. Use `cdkConnectedOverlayScrollStrategy` instead. * `backdropClass` which was deprecated in 5.0.0 has been removed. Use `cdkConnectedOverlayBackdropClass` instead. * `minHeight` which was deprecated in 5.0.0 has been removed. Use `cdkConnectedOverlayMinHeight` instead. * `minWidth` which was deprecated in 5.0.0 has been removed. Use `cdkConnectedOverlayMinWidth` instead. * `height` which was deprecated in 5.0.0 has been removed. Use `cdkConnectedOverlayHeight` instead. * `width` which was deprecated in 5.0.0 has been removed. Use `cdkConnectedOverlayWidth` instead. * `offsetX` which was deprecated in 5.0.0 has been removed. Use `cdkConnectedOverlayOffsetX` instead. * `offsetY` which was deprecated in 5.0.0 has been removed. Use `cdkConnectedOverlayOffsetY` instead. * `positions` which was deprecated in 5.0.0 has been removed. Use `cdkConnectedOverlayPositions` instead. * `origin` which was deprecated in 5.0.0 has been removed. Use `cdkConnectedOverlayOrigin` instead.
crisbeto
force-pushed
the
overlay-deletion-targets
branch
from
3aafe34 to
0f2bc8d
Compare
Member
Author
|
Done. |
jelbourn
added
pr: lgtm
action: merge
Member
|
Caretaker note: we need to remove google usages of the old API. This might require a cleanup before syncing this PR. |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes all of the APIs that were marked for deletion in 6.0.0 from the
cdk/overlayentry point.BREAKING CHANGES:
ConnectedOverlayDirectivewhich was deprecated in 5.0.0 has been removed. UseCdkConnectedOverlayinstead.OverlayOriginwhich was deprecated in 5.0.0 has been removed. UseCdkOverlayOrigininstead.hasBackdropwhich was deprecated in 5.0.0 has been removed. UsecdkConnectedOverlayHasBackdropinstead.openwhich was deprecated in 5.0.0 has been removed. UsecdkConnectedOverlayOpeninstead.scrollStrategywhich was deprecated in 5.0.0 has been removed. UsecdkConnectedOverlayScrollStrategyinstead.backdropClasswhich was deprecated in 5.0.0 has been removed. UsecdkConnectedOverlayBackdropClassinstead.minHeightwhich was deprecated in 5.0.0 has been removed. UsecdkConnectedOverlayMinHeightinstead.minWidthwhich was deprecated in 5.0.0 has been removed. UsecdkConnectedOverlayMinWidthinstead.heightwhich was deprecated in 5.0.0 has been removed. UsecdkConnectedOverlayHeightinstead.widthwhich was deprecated in 5.0.0 has been removed. UsecdkConnectedOverlayWidthinstead.offsetXwhich was deprecated in 5.0.0 has been removed. UsecdkConnectedOverlayOffsetXinstead.offsetYwhich was deprecated in 5.0.0 has been removed. UsecdkConnectedOverlayOffsetYinstead.positionswhich was deprecated in 5.0.0 has been removed. UsecdkConnectedOverlayPositionsinstead.originwhich was deprecated in 5.0.0 has been removed. UsecdkConnectedOverlayOrigininstead.