Skip to content

Commit 54252d5

Browse files
crisbetommalerba
authored andcommitted
refactor(overlay): remove 6.0.0 deletion targets (#10161)
Removes all of the APIs that were marked for deletion in 6.0.0 from the `cdk/overlay` entry point. BREAKING CHANGES: * `ConnectedOverlayDirective` which was deprecated in 5.0.0 has been removed. Use `CdkConnectedOverlay` instead. * `OverlayOrigin` which was deprecated in 5.0.0 has been removed. Use `CdkOverlayOrigin` instead. * `hasBackdrop` which was deprecated in 5.0.0 has been removed. Use `cdkConnectedOverlayHasBackdrop` instead. * `open` which was deprecated in 5.0.0 has been removed. Use `cdkConnectedOverlayOpen` instead. * `scrollStrategy` which was deprecated in 5.0.0 has been removed. Use `cdkConnectedOverlayScrollStrategy` instead. * `backdropClass` which was deprecated in 5.0.0 has been removed. Use `cdkConnectedOverlayBackdropClass` instead. * `minHeight` which was deprecated in 5.0.0 has been removed. Use `cdkConnectedOverlayMinHeight` instead. * `minWidth` which was deprecated in 5.0.0 has been removed. Use `cdkConnectedOverlayMinWidth` instead. * `height` which was deprecated in 5.0.0 has been removed. Use `cdkConnectedOverlayHeight` instead. * `width` which was deprecated in 5.0.0 has been removed. Use `cdkConnectedOverlayWidth` instead. * `offsetX` which was deprecated in 5.0.0 has been removed. Use `cdkConnectedOverlayOffsetX` instead. * `offsetY` which was deprecated in 5.0.0 has been removed. Use `cdkConnectedOverlayOffsetY` instead. * `positions` which was deprecated in 5.0.0 has been removed. Use `cdkConnectedOverlayPositions` instead. * `origin` which was deprecated in 5.0.0 has been removed. Use `cdkConnectedOverlayOrigin` instead.
1 parent 9403ead commit 54252d5

File tree

5 files changed

+28
-124
lines changed

5 files changed

+28
-124
lines changed

src/cdk/overlay/overlay-directives.spec.ts

Lines changed: 14 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -402,12 +402,21 @@ describe('Overlay directives', () => {
402402
<button cdk-overlay-origin id="trigger" #trigger="cdkOverlayOrigin">Toggle menu</button>
403403
<button cdk-overlay-origin id="otherTrigger" #otherTrigger="cdkOverlayOrigin">Toggle menu</button>
404404
405-
<ng-template cdk-connected-overlay [open]="isOpen" [width]="width" [height]="height"
405+
<ng-template cdk-connected-overlay
406+
[cdkConnectedOverlayOpen]="isOpen"
407+
[cdkConnectedOverlayWidth]="width"
408+
[cdkConnectedOverlayHeight]="height"
406409
[cdkConnectedOverlayOrigin]="triggerOverride || trigger"
407-
[hasBackdrop]="hasBackdrop" backdropClass="mat-test-class"
408-
(backdropClick)="backdropClickHandler($event)" [offsetX]="offsetX" [offsetY]="offsetY"
409-
(positionChange)="positionChangeHandler($event)" (attach)="attachHandler()"
410-
(detach)="detachHandler()" [minWidth]="minWidth" [minHeight]="minHeight"
410+
[cdkConnectedOverlayHasBackdrop]="hasBackdrop"
411+
cdkConnectedOverlayBackdropClass="mat-test-class"
412+
(backdropClick)="backdropClickHandler($event)"
413+
[cdkConnectedOverlayOffsetX]="offsetX"
414+
[cdkConnectedOverlayOffsetY]="offsetY"
415+
(positionChange)="positionChangeHandler($event)"
416+
(attach)="attachHandler()"
417+
(detach)="detachHandler()"
418+
[cdkConnectedOverlayMinWidth]="minWidth"
419+
[cdkConnectedOverlayMinHeight]="minHeight"
411420
[cdkConnectedOverlayPositions]="positionOverrides">
412421
<p>Menu content</p>
413422
</ng-template>`,

src/cdk/overlay/overlay-directives.ts

Lines changed: 0 additions & 98 deletions
Original file line numberDiff line numberDiff line change
@@ -161,104 +161,6 @@ export class CdkConnectedOverlay implements OnDestroy, OnChanges {
161161
get lockPosition() { return this._lockPosition; }
162162
set lockPosition(value: any) { this._lockPosition = coerceBooleanProperty(value); }
163163

164-
/**
165-
* @deprecated
166-
* @deletion-target 6.0.0
167-
*/
168-
@Input('origin')
169-
get _deprecatedOrigin(): CdkOverlayOrigin { return this.origin; }
170-
set _deprecatedOrigin(_origin: CdkOverlayOrigin) { this.origin = _origin; }
171-
172-
/**
173-
* @deprecated
174-
* @deletion-target 6.0.0
175-
*/
176-
@Input('positions')
177-
get _deprecatedPositions(): ConnectionPositionPair[] { return this.positions; }
178-
set _deprecatedPositions(_positions: ConnectionPositionPair[]) { this.positions = _positions; }
179-
180-
/**
181-
* @deprecated
182-
* @deletion-target 6.0.0
183-
*/
184-
@Input('offsetX')
185-
get _deprecatedOffsetX(): number { return this.offsetX; }
186-
set _deprecatedOffsetX(_offsetX: number) { this.offsetX = _offsetX; }
187-
188-
/**
189-
* @deprecated
190-
* @deletion-target 6.0.0
191-
*/
192-
@Input('offsetY')
193-
get _deprecatedOffsetY(): number { return this.offsetY; }
194-
set _deprecatedOffsetY(_offsetY: number) { this.offsetY = _offsetY; }
195-
196-
/**
197-
* @deprecated
198-
* @deletion-target 6.0.0
199-
*/
200-
@Input('width')
201-
get _deprecatedWidth(): number | string { return this.width; }
202-
set _deprecatedWidth(_width: number | string) { this.width = _width; }
203-
204-
/**
205-
* @deprecated
206-
* @deletion-target 6.0.0
207-
*/
208-
@Input('height')
209-
get _deprecatedHeight(): number | string { return this.height; }
210-
set _deprecatedHeight(_height: number | string) { this.height = _height; }
211-
212-
/**
213-
* @deprecated
214-
* @deletion-target 6.0.0
215-
*/
216-
@Input('minWidth')
217-
get _deprecatedMinWidth(): number | string { return this.minWidth; }
218-
set _deprecatedMinWidth(_minWidth: number | string) { this.minWidth = _minWidth; }
219-
220-
/**
221-
* @deprecated
222-
* @deletion-target 6.0.0
223-
*/
224-
@Input('minHeight')
225-
get _deprecatedMinHeight(): number | string { return this.minHeight; }
226-
set _deprecatedMinHeight(_minHeight: number | string) { this.minHeight = _minHeight; }
227-
228-
/**
229-
* @deprecated
230-
* @deletion-target 6.0.0
231-
*/
232-
@Input('backdropClass')
233-
get _deprecatedBackdropClass(): string { return this.backdropClass; }
234-
set _deprecatedBackdropClass(_backdropClass: string) { this.backdropClass = _backdropClass; }
235-
236-
/**
237-
* @deprecated
238-
* @deletion-target 6.0.0
239-
*/
240-
@Input('scrollStrategy')
241-
get _deprecatedScrollStrategy(): ScrollStrategy { return this.scrollStrategy; }
242-
set _deprecatedScrollStrategy(_scrollStrategy: ScrollStrategy) {
243-
this.scrollStrategy = _scrollStrategy;
244-
}
245-
246-
/**
247-
* @deprecated
248-
* @deletion-target 6.0.0
249-
*/
250-
@Input('open')
251-
get _deprecatedOpen(): boolean { return this.open; }
252-
set _deprecatedOpen(_open: boolean) { this.open = _open; }
253-
254-
/**
255-
* @deprecated
256-
* @deletion-target 6.0.0
257-
*/
258-
@Input('hasBackdrop')
259-
get _deprecatedHasBackdrop() { return this.hasBackdrop; }
260-
set _deprecatedHasBackdrop(_hasBackdrop: any) { this.hasBackdrop = _hasBackdrop; }
261-
262164
/** Event emitted when the backdrop is clicked. */
263165
@Output() backdropClick = new EventEmitter<MouseEvent>();
264166

src/cdk/overlay/public-api.ts

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -25,15 +25,3 @@ export {PositionStrategy} from './position/position-strategy';
2525
export {GlobalPositionStrategy} from './position/global-position-strategy';
2626
export {ConnectedPositionStrategy} from './position/connected-position-strategy';
2727
export {VIEWPORT_RULER_PROVIDER} from '@angular/cdk/scrolling';
28-
29-
/**
30-
* @deprecated Use CdkConnectedOverlay
31-
* @deletion-target 6.0.0
32-
*/
33-
export {CdkConnectedOverlay as ConnectedOverlayDirective} from './overlay-directives';
34-
35-
/**
36-
* @deprecated Use CdkOverlayOrigin
37-
* @deletion-target 6.0.0
38-
*/
39-
export {CdkOverlayOrigin as OverlayOrigin} from './overlay-directives';

src/demo-app/overlay/overlay-demo.html

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,12 @@
1919
Open menu
2020
</button>
2121

22-
<ng-template cdk-connected-overlay [origin]="trigger" [width]="500" hasBackdrop [open]="isMenuOpen"
22+
<ng-template
23+
cdk-connected-overlay
24+
[cdkConnectedOverlayOrigin]="trigger"
25+
[cdkConnectedOverlayWidth]="500"
26+
cdkConnectedOverlayHasBackdrop
27+
[cdkConnectedOverlayOpen]="isMenuOpen"
2328
(backdropClick)="isMenuOpen=false">
2429
<div style="background-color: mediumpurple" >
2530
This is the menu panel.

src/lib/select/select.html

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -17,15 +17,15 @@
1717

1818
<ng-template
1919
cdk-connected-overlay
20-
hasBackdrop
20+
cdkConnectedOverlayHasBackdrop
2121
cdkConnectedOverlayLockPosition
22-
backdropClass="cdk-overlay-transparent-backdrop"
23-
[scrollStrategy]="_scrollStrategy"
24-
[origin]="origin"
25-
[open]="panelOpen"
26-
[positions]="_positions"
27-
[minWidth]="_triggerRect?.width"
28-
[offsetY]="_offsetY"
22+
cdkConnectedOverlayBackdropClass="cdk-overlay-transparent-backdrop"
23+
[cdkConnectedOverlayScrollStrategy]="_scrollStrategy"
24+
[cdkConnectedOverlayOrigin]="origin"
25+
[cdkConnectedOverlayOpen]="panelOpen"
26+
[cdkConnectedOverlayPositions]="_positions"
27+
[cdkConnectedOverlayMinWidth]="_triggerRect?.width"
28+
[cdkConnectedOverlayOffsetY]="_offsetY"
2929
(backdropClick)="close()"
3030
(attach)="_onAttached()"
3131
(detach)="close()">

0 commit comments

Comments
 (0)