Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ env:
matrix:
- DJANGO=">=1.7,<1.8"
- DJANGO=">=1.8,<1.9"
- DJANGO=">=1.9,<1.10"
install:
- pip install -q coverage flake8 Django$DJANGO django-nose>=1.4
- python setup.py install
Expand Down
1 change: 0 additions & 1 deletion db_mutex/__init__.py
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
# flake8: noqa
from .db_mutex import db_mutex
from .exceptions import DBMutexError, DBMutexTimeoutError
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wesokes any reason this was removed? If the new API doesn't support

from db_mutex import db_mutex

then you will want to update the doc examples. I was following the doc examples and it errored :/ Let me know if you want me to revert back to the old API or fix the docs. Either is fine

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry, i can update the docs. any package that was importing a model in the init had to be changed during the django 1.9 upgrade so that models are not imported before django initializes all apps.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wesleykendall looks like there was just one code example using the old import. most of our other projects were updated as well so all model imports look like from package.models import Model

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah I remember that update. Thanks!

from .version import __version__

Expand Down
2 changes: 1 addition & 1 deletion db_mutex/tests/db_mutex_tests.py
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@

from db_mutex.exceptions import DBMutexError, DBMutexTimeoutError
from db_mutex.models import DBMutex
from db_mutex import db_mutex
from db_mutex.db_mutex import db_mutex

from django.test import TestCase
from django.test.utils import override_settings
Expand Down
2 changes: 1 addition & 1 deletion db_mutex/version.py
Original file line number Diff line number Diff line change
@@ -1 +1 @@
__version__ = '0.2.3'
__version__ = '0.3.0'
4 changes: 0 additions & 4 deletions run_tests.py
Original file line number Diff line number Diff line change
@@ -1,14 +1,10 @@
import sys
from optparse import OptionParser

import django

from settings import configure_settings


# Configure the default settings
configure_settings()
django.setup()

# Django nose must be imported here since it depends on the settings being configured
from django_nose import NoseTestSuiteRunner # noqa
Expand Down
1 change: 1 addition & 0 deletions setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@ def get_version():
'Framework :: Django',
'Framework :: Django :: 1.7',
'Framework :: Django :: 1.8',
'Framework :: Django :: 1.9',
],
license='MIT',
install_requires=[
Expand Down