Skip to content

Conversation

@somewes
Copy link
Contributor

@somewes somewes commented Feb 17, 2016

No description provided.

somewes added a commit that referenced this pull request Feb 17, 2016
update master with django 1.9 support
@somewes somewes merged commit cd5eb70 into master Feb 17, 2016
@@ -1,5 +1,4 @@
# flake8: noqa
from .db_mutex import db_mutex
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wesokes any reason this was removed? If the new API doesn't support

from db_mutex import db_mutex

then you will want to update the doc examples. I was following the doc examples and it errored :/ Let me know if you want me to revert back to the old API or fix the docs. Either is fine

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry, i can update the docs. any package that was importing a model in the init had to be changed during the django 1.9 upgrade so that models are not imported before django initializes all apps.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wesleykendall looks like there was just one code example using the old import. most of our other projects were updated as well so all model imports look like from package.models import Model

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah I remember that update. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants