Skip to content

Use extended_json_encoder as default in ClientSession #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 29, 2023
Merged

Use extended_json_encoder as default in ClientSession #84

merged 4 commits into from
Nov 29, 2023

Conversation

@MHHukiewitz
Copy link
Member

@MHHukiewitz MHHukiewitz commented Nov 27, 2023

No description provided.

@github-actions github-actions bot added the BLACK This PR has critical implications and must be reviewed by a senior engineer. label Nov 27, 2023
@github-actions
Copy link

github-actions bot commented Nov 27, 2023

Reason: The change modifies the way data is serialized in a critical part of the codebase. This modification could potentially introduce bugs or unexpected behavior if not carefully reviewed.

  • Modification of JSON serialization (json.dumps(message_dict, default=extended_json_encoder)) which may impact how data is transmitted and processed by other components in the system.
  • The change affects a critical part of the codebase (authenticated HTTP client).

@MHHukiewitz MHHukiewitz force-pushed the mhh-fix-broadcast-datetime branch from cbdcd2b to 2dcece2 Compare November 27, 2023 16:50
@MHHukiewitz MHHukiewitz changed the title Use extended_json_encoder when dumping message contents everywhere 2 Use extended_json_encoder as default in ClientSession Nov 28, 2023
hoh
hoh reviewed Nov 28, 2023
View reviewed changes
Copy link
Member

@hoh hoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you make sure to solve the missing timezones from #82 as well ?

@MHHukiewitz MHHukiewitz requested a review from aliel November 29, 2023 10:54
1yam
1yam approved these changes Nov 29, 2023
View reviewed changes
Copy link
Member

@1yam 1yam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MHHukiewitz MHHukiewitz merged commit 9ec197f into main Nov 29, 2023
@MHHukiewitz MHHukiewitz deleted the mhh-fix-broadcast-datetime branch November 29, 2023 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@hoh hoh hoh left review comments

@1yam 1yam 1yam approved these changes

@aliel aliel Awaiting requested review from aliel

Assignees

No one assigned

Labels

BLACK This PR has critical implications and must be reviewed by a senior engineer.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@MHHukiewitz @hoh @1yam