Skip to content

Conversation

@MHHukiewitz
Copy link
Member

@github-actions github-actions bot added the BLACK This PR has critical implications and must be reviewed by a senior engineer. label Nov 25, 2023
@github-actions
Copy link

  • Addition of a new function extended_json_encoder which handles serialization for various datetime types. This is a significant change as it affects the way data is encoded and decoded in the application.
  • Modification of the _prepare_aleph_message function to use the new extended_json_encoder instead of the previous encoder pydantic_encoder. This could potentially introduce bugs if the new encoder does not handle all cases that the previous encoder handled.

@MHHukiewitz MHHukiewitz force-pushed the mhh-od-serialize-datetime branch from 1c94889 to 8246a26 Compare November 27, 2023 14:03
@MHHukiewitz MHHukiewitz requested a review from 1yam November 27, 2023 14:04
Copy link
Member

@1yam 1yam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MHHukiewitz MHHukiewitz merged commit b11349b into main Nov 27, 2023
@MHHukiewitz MHHukiewitz deleted the mhh-od-serialize-datetime branch November 27, 2023 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

BLACK This PR has critical implications and must be reviewed by a senior engineer.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants