Feature : AlephDNS (2nd attempt) #55
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aliel
force-pushed
the
alephdns
branch
2 times, most recently
from
b8d1dfe to
4ff1ade
Compare
aliel
requested review from
ricardocr987
and removed request for
ricardocr987
hoh
commented
Oct 23, 2023
hoh
commented
Oct 23, 2023
Member
* Feature : AlephDNS add instances support add ipfs support add program support --------- Co-authored-by: aliel <[email protected]>
github-actions
bot
added
the
RED
The complexity of the changes necessitates a thorough review to understand the added features and ensure that they align with the project's architecture and best practices. Additionally, the impact on existing functionality may require careful consideration and testing. This PR should be reviewed by an experienced developer who is familiar with the project and has knowledge of the technologies involved (Python, aiodns). |
aliel
approved these changes
Nov 21, 2023
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous Pull Request #47 failed to match our standards, broke PEP8 and code quality and caused issues for further development.
This is a new Pull Request aiming at getting these changes merged.
add ipfs support
add program support