Feature: add custom domain support #167
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aliel
force-pushed
the
aliel-add-custom-domains-support
branch
2 times, most recently
from
9b77354 to
1fe4a09
Compare
MHHukiewitz
force-pushed
the
aliel-add-custom-domains-support
branch
from
efc265a to
30e19e8
Compare
MHHukiewitz
added
the
BLACK
Member
|
Assigned BLACK, as it exceeds Llama context size |
aliel
force-pushed
the
aliel-add-custom-domains-support
branch
from
ee808e8 to
ad84357
Compare
Member
|
CI/CD fails because of an oversight on my side... There's two different ways messages are being returned from the API.
The recent merge of aleph-im/aleph-sdk-python#81 now pulls messages from endpoint 2) and therefore validation of the This PR aleph-im/aleph-message#40 should fix it. |
MHHukiewitz
suggested changes
Nov 22, 2023
Member
MHHukiewitz
left a comment
MHHukiewitz
left a comment
There was a problem hiding this comment.
LGTM, only necessary change is to replace @coro annotations by using app = AsyncTyper() from aleph_client.utils
MHHukiewitz
force-pushed
the
aliel-add-custom-domains-support
branch
from
7539a33 to
d2a5c25
Compare
MHHukiewitz
reviewed
Nov 29, 2023
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@hoh
to review/merge after =>
aleph-im/aleph-sdk-python#55