Skip to content

Conversation

@philogicae
Copy link
Member

No description provided.

@philogicae philogicae requested a review from nesitor August 29, 2024 14:05
@github-actions github-actions bot added the BLUE This PR is simple and straightforward. label Aug 29, 2024
@github-actions
Copy link

"summary": "This PR introduces changes to the configuration and environment setup of the Aleph.im SDK. The changes include updates to the .env.example, .gitignore, and src/aleph/sdk/conf.py files. Additionally, there are updates to the settings and environment variables for the SDK. The changes are focused on improving the configuration and environment setup, which are likely to be minor modifications that do not introduce significant risks.",
"highlight": [
"new file mode 100644 a/.env.example",
"new file mode 100644 a/.gitignore",
"index 38afc381..fc7f9d6b 100644 a/src/aleph/sdk/conf.py",
"DEFAULT_CONFIDENTIAL_FIRMWARE",
"DEFAULT_CONFIDENTIAL_FIRMWARE_HASH",
"DEFAULT_ROOTFS_SIZE",
"DEFAULT_INSTANCE_MEMORY",
"DEFAULT_HYPERVISOR",
"VM_URL_PATH",
"VM_URL_HOST",
"CHAINS_ENV",
"settings.delattr(f"CHAINS_{fields}")"
]
}

1yam
1yam previously approved these changes Aug 30, 2024
Copy link
Member

@1yam 1yam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hoh hoh merged commit 1bc6a4f into main Sep 3, 2024
@philogicae philogicae deleted the fix-settings branch September 3, 2024 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

BLUE This PR is simple and straightforward.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants