-
Notifications
You must be signed in to change notification settings - Fork 15
Various fixes after 1.0.0 #262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #262 +/- ##
==========================================
- Coverage 40.62% 38.78% -1.84%
==========================================
Files 19 18 -1
Lines 1930 1921 -9
Branches 332 333 +1
==========================================
- Hits 784 745 -39
- Misses 1109 1140 +31
+ Partials 37 36 -1 ☔ View full report in Codecov by Sentry. |
1db9c4b to
f606ad3
Compare
|
Failed to retrieve llama text: POST 504: 504 Gateway Time-outThe server didn't respond in time. |
fd9f598 to
a2e40e3
Compare
hoh
reviewed
Sep 3, 2024
hoh
reviewed
Sep 4, 2024
4bf5eed to
364eae5
Compare
…ery cmd -> better UX
typer.style, typer.colors -> from typer import style, colors
d038793 to
f82e6c5
Compare
hoh
approved these changes
Sep 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes for post-1.0.0 release / Base integration [Changes below]
Self proofreading checklist
Documentation
TODO / Check at the end of the week
Changes
instance confidential: optional crn_url + explicit args for internal cmds: commitfetch_vm_info()into network.py: commitinstance list: filter out forgotten/invalid instances: commitinstance list: add "chain" of payment + change item_url -> explorer_url: commitfind_crn_of_vm(vm_id)-> make crn_url/domain optional for every cmd: commitsettings, now completely delegated to SDK to avoid conf issues: commitinstance logswhen no VM is running: commitInstance listfix on exceptions/debug: commitNFT payment-type(fallbacking to hold-tier) + Fix helpers + format: commitHow to test
Create some instances (PAYG and/or confidential on Base) and play around with commands (list, logs, delete).
Notes