Skip to content

Conversation

@philogicae
Copy link
Member

@philogicae philogicae commented Aug 28, 2024

Fixes for post-1.0.0 release / Base integration [Changes below]

Self proofreading checklist

  • The new code clear, easy to read and well commented.
  • New code does not duplicate the functions of builtin or popular libraries.
  • An LLM was used to review the new code and look for simplifications.
  • New classes and functions contain docstrings explaining what they provide.
  • All new code is covered by relevant tests.

Documentation

TODO / Check at the end of the week

Changes

  • Add default rootfs when prompting: commit
  • Fix cmd instance confidential: optional crn_url + explicit args for internal cmds: commit
  • Move new fetch_vm_info() into network.py: commit
  • has_nested_attr() -> safe_getattr(): commit
  • Fix instance list: filter out forgotten/invalid instances: commit
  • Add BASE chain: commit
  • Improve instance list: add "chain" of payment + change item_url -> explorer_url: commit
  • Fix PAYG: erase instance before stopping flow + ensure to properly delete infinitesimal leftover flows: commit
  • Feature: new find_crn_of_vm(vm_id) -> make crn_url/domain optional for every cmd: commit
  • Fix displayed message (last commit allows auto crn domain detection): commit
  • Fix settings, now completely delegated to SDK to avoid conf issues: commit
  • Fix instance logs when no VM is running: commit
  • Instance list fix on exceptions/debug: commit
  • Add NFT payment-type (fallbacking to hold-tier) + Fix helpers + format: commit

How to test

Create some instances (PAYG and/or confidential on Base) and play around with commands (list, logs, delete).

Notes

  • New SDK version needs to be released in order to merge this PR properly.

@philogicae philogicae changed the title Add default rootfs when prompting Various fixes after 1.0.0 Aug 28, 2024
@codecov
Copy link

codecov bot commented Aug 28, 2024

Codecov Report

Attention: Patch coverage is 40.20619% with 116 lines in your changes missing coverage. Please review.

Project coverage is 38.78%. Comparing base (37fac02) to head (f82e6c5).
Report is 16 commits behind head on master.

Files with missing lines Patch % Lines
src/aleph_client/commands/instance/__init__.py 25.42% 40 Missing and 4 partials ⚠️
src/aleph_client/commands/instance/network.py 50.74% 30 Missing and 3 partials ⚠️
src/aleph_client/commands/utils.py 40.00% 17 Missing and 1 partial ⚠️
src/aleph_client/commands/message.py 50.00% 4 Missing ⚠️
src/aleph_client/commands/program.py 42.85% 4 Missing ⚠️
src/aleph_client/commands/account.py 40.00% 2 Missing and 1 partial ⚠️
src/aleph_client/commands/aggregate.py 25.00% 3 Missing ⚠️
src/aleph_client/commands/domain.py 25.00% 3 Missing ⚠️
src/aleph_client/commands/files.py 50.00% 3 Missing ⚠️
src/aleph_client/commands/instance/superfluid.py 0.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #262      +/-   ##
==========================================
- Coverage   40.62%   38.78%   -1.84%     
==========================================
  Files          19       18       -1     
  Lines        1930     1921       -9     
  Branches      332      333       +1     
==========================================
- Hits          784      745      -39     
- Misses       1109     1140      +31     
+ Partials       37       36       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@philogicae philogicae force-pushed the fix-various-fixes-after-1.0.0 branch 3 times, most recently from 1db9c4b to f606ad3 Compare August 28, 2024 20:32
@philogicae philogicae marked this pull request as ready for review August 28, 2024 22:41
@philogicae philogicae requested review from 1yam, hoh and olethanh August 28, 2024 22:50
@github-actions
Copy link

Failed to retrieve llama text: POST 504:

504 Gateway Time-out


The server didn't respond in time.

@philogicae philogicae force-pushed the fix-various-fixes-after-1.0.0 branch 2 times, most recently from fd9f598 to a2e40e3 Compare September 3, 2024 14:32
@philogicae philogicae force-pushed the fix-various-fixes-after-1.0.0 branch from 4bf5eed to 364eae5 Compare September 4, 2024 12:22
@philogicae philogicae requested a review from hoh September 4, 2024 12:35
philogicae and others added 2 commits September 4, 2024 15:24
typer.style, typer.colors -> from typer import style, colors
@hoh hoh force-pushed the fix-various-fixes-after-1.0.0 branch from d038793 to f82e6c5 Compare September 4, 2024 13:35
@hoh hoh merged commit 98f1f07 into master Sep 4, 2024
@hoh hoh deleted the fix-various-fixes-after-1.0.0 branch September 4, 2024 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants