Skip to content

[assurance] clean up assurance package & update public docs with typescript syntax #158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 30, 2022
Merged

[assurance] clean up assurance package & update public docs with typescript syntax #158

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b821626
clean up Assurance package and update docs with typescript syntax
yangyansong-adbe Mar 29, 2022
764a49d
remove app id
yangyansong-adbe Mar 29, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 0 additions & 13 deletions apps/AEPSampleApp/android/app/src/debug/AndroidManifest.xml
View file
Open in desktop

This file was deleted.

44 changes: 27 additions & 17 deletions apps/AEPSampleApp/android/app/src/main/AndroidManifest.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,25 +1,35 @@
<manifest xmlns:android="http://schemas.android.com/apk/res/android"
package="com.aepsampleapp">
package="com.aepsampleapp">

<uses-permission android:name="android.permission.INTERNET" />
<uses-permission android:name="android.permission.ACCESS_NETWORK_STATE" />

<application
android:name=".MainApplication"
android:label="@string/app_name"
android:icon="@mipmap/ic_launcher"
android:roundIcon="@mipmap/ic_launcher_round"
android:allowBackup="false"
android:theme="@style/AppTheme">
<activity
android:name=".MainActivity"
android:name=".MainApplication"
android:label="@string/app_name"
android:configChanges="keyboard|keyboardHidden|orientation|screenSize|uiMode"
android:launchMode="singleTask"
android:windowSoftInputMode="adjustResize">
<intent-filter>
<action android:name="android.intent.action.MAIN" />
<category android:name="android.intent.category.LAUNCHER" />
</intent-filter>
</activity>
android:icon="@mipmap/ic_launcher"
android:roundIcon="@mipmap/ic_launcher_round"
android:allowBackup="false"
android:theme="@style/AppTheme">
<activity
android:name=".MainActivity"
android:label="@string/app_name"
android:configChanges="keyboard|keyboardHidden|orientation|screenSize|uiMode"
android:launchMode="singleTask"
android:windowSoftInputMode="adjustResize">
<intent-filter>
<action android:name="android.intent.action.MAIN" />
<category android:name="android.intent.category.LAUNCHER" />
</intent-filter>
<intent-filter>
<action android:name="android.intent.action.VIEW" />

<category android:name="android.intent.category.DEFAULT" />
<category android:name="android.intent.category.LAUNCHER" />
<category android:name="android.intent.category.BROWSABLE" />

<data android:scheme="assurance" />
</intent-filter>
</activity>
</application>
</manifest>
2 changes: 1 addition & 1 deletion apps/AEPSampleApp/ios/AEPSampleApp/Info.plist
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@
<array>
<dict>
<key>CFBundleTypeRole</key>
<string>Editor</string>
<string>Viewer</string>
<key>CFBundleURLName</key>
<string>Assurance URL</string>
<key>CFBundleURLSchemes</key>
Expand Down
2 changes: 1 addition & 1 deletion packages/assurance/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ To connect to a griffon session by scanning the QR code. Follow the [Android doc

##### Start Assurance session:

```javascript
```typescript
import {Assurance} from '@adobe/react-native-aepassurance';
Assurance.startSession("{your-assurance-session-url}");
```
Binary file removed packages/assurance/android/gradle/wrapper/gradle-wrapper.jar
View file
Open in desktop
Binary file not shown.
6 changes: 0 additions & 6 deletions packages/assurance/android/gradle/wrapper/gradle-wrapper.properties
View file
Open in desktop

This file was deleted.

172 changes: 0 additions & 172 deletions packages/assurance/android/gradlew
View file
Open in desktop

This file was deleted.

84 changes: 0 additions & 84 deletions packages/assurance/android/gradlew.bat
View file
Open in desktop

This file was deleted.

2 changes: 1 addition & 1 deletion packages/assurance/ts/Assurance.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ const RCTAEPAssurance: IAssurance = NativeModules.AEPAssurance;
const Assurance: IAssurance = {
/**
* Returns the version of the Assurance extension.
* @param {string} Promise a promise that resolves with the extension version
* @return {string} Promise a promise that resolves with the extension version
*/
extensionVersion(): Promise<string> {
return Promise.resolve(RCTAEPAssurance.extensionVersion());
Expand Down