Skip to content

Conversation

@yangyansong-adbe
Copy link
Contributor

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@cacheung
Copy link
Contributor

Looks good. One comment.
How about change the text here
https://github.com/adobe/aepsdk-react-native/blob/assurance/apps/AEPSampleApp/extensions/AssuranceView.tsx#L41

From "Paste your Assurance Session URL" to "assurance://..." So user know this is the Assurance URL to use for this sample app?

@yangyansong-adbe yangyansong-adbe merged commit c2baa57 into staging Mar 30, 2022
yangyansong-adbe added a commit that referenced this pull request Apr 4, 2022
* commit '80111f1f84adc38d2a5038d3c6f47c95d1103059':
  add back android manifest for debug
  Clean up Consent package
  remove babelrc file
  [assurance] clean up assurance package & update public docs with typescript syntax (#158)
  Clean up for EdgeIdentity and update readme.
  [core] clean up core package & update public docs with typescript syntax  (#157)
  Clean up for Edge extension
  Staging -> Main for Edge beta.2 release (#151)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants