[userprofile] clean up userprofile package & update public docs with typescript syntax #155
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* commit 'a6776050d3d7dff8ec244d431174f522de40e605': Update README.md Update README.md typo fix android app launching issue Create README.md Update badges on readme bump version (#21) (#23) bump version (#20) remove user data Fix CI (out-of-memory) failure (#18) Update package.json Update npm-publish.yml Add release script (#17) Update README.md (#16) more project cleanup (#15) Init project (#14)
* staging: Update READMEs (#24)
* commit '78ac4b265b4f36764680c1518c18efa15f32835a': Update README.md [userprofile - staging] clean up package (#28)
* staging: (69 commits) Fix link Link to assurance install instructions Update the package name Update the broken reactnative homepage link Warning Note downloading wrong Assurance version Update readme for installation of Assurance alpa version Added gitignore in messaging package and minor change in Readme. Update README.md Updated the Readme as per code review feedback. Updated Readme.md Code review feedback Updated Readme for Messaging RN package Update edge package.json with edgeidentity as dependency (#41) fix unit test Update podfile and minor clean up Update readme extensions download path Update podfile Update edge Identity version number Update edge extension version number Update with review comments ...
* UserProfile (1.0.0-alpha.3) -> staging (#50) (#51) * UserProfile (1.0.0-alpha.3) -> staging (#50) (#53) * Edge (1.0.0-alpha.2), Messaging (1.0.0-alpha.2) -> staging (#54) * quick fix for peerDependecies issue * update sample app dependencies to latest versions * Update Edge Wrapper Readme Update Edge Wrapper Readme * update readme update readme * Edge (1.0.0-alpha.2), Messaging (1.0.0-alpha.2) -> main (#55) * EdgeIdentity (1.0.0-alpha.2) -> staging (#59) * fix a typo in readme (#61) fix a typo in readme * EdgeIdentity (1.0.0-alpha.2) -> main (#62) * add a new API in Core - resetIdentities (#63) (#64) * add a new API in Core -? resetIdentities * update core package version to alpha.2 * Update README.md * Core (1.0.0-alpha.2) -> main (#65) * add a FAQ section (#66) * Consent package setup * update dependencies * Fix consent module * Add consent to iOS sample app * Renaming, update dependencies * Update gradle * Added APIs for Consent extension (#80) * Consent - add Android + JS APIs, update sample app * Consent - sample app styling * Consent - iOS API updates, update examples on sample app * Consent - update typescript def and tests * Consent - update documentation * Consent - docs updates * Consent - reject with AEPError * Consent - add to main readme * Consent - review update sample app * fix the release issue: NPM registry enforces a minimum of TLS 1.2 beginning October 4, 2021 (#73) * Consent - renaming public JS classes (#93) * Consent - renaming for consistency with native classes * Consent - AEP renaming * Consent - updated return promise * Pods update * Core - renaming public JS classes (#102) * add a new API in Core - resetIdentities (#63) * add a new API in Core -? resetIdentities * update core package version to alpha.2 * Merge latest staging changes (#85) * EdgeIdentity (1.0.0-alpha.2) -> main (#62) * add a new API in Core -? resetIdentities * update core package version to alpha.2 * add a new API in Core - resetIdentities (#63) (#64) * add a new API in Core -? resetIdentities * update core package version to alpha.2 * Update README.md * add a FAQ section (#66) * fix the release issue: NPM registry enforces a minimum of TLS 1.2 beginning October 4, 2021 (#73) * Reduce visibility for utility classes and handle error callback (#86) * EdgeIdentity (1.0.0-alpha.2) -> main (#62) * add a new API in Core -? resetIdentities * update core package version to alpha.2 * add a new API in Core - resetIdentities (#63) (#64) * add a new API in Core -? resetIdentities * update core package version to alpha.2 * Update README.md * add a FAQ section (#66) * fix the release issue: NPM registry enforces a minimum of TLS 1.2 beginning October 4, 2021 (#73) * reduce visibility for utility classes. * handle error callback * address review comments * Core - renaming public APIs (#91) * EdgeIdentity (1.0.0-alpha.2) -> main (#62) * add a new API in Core -? resetIdentities * update core package version to alpha.2 * add a new API in Core - resetIdentities (#63) (#64) * add a new API in Core -? resetIdentities * update core package version to alpha.2 * Update README.md * add a FAQ section (#66) * fix the release issue: NPM registry enforces a minimum of TLS 1.2 beginning October 4, 2021 (#73) * reduce visibility for utility classes. * handle error callback * rename public APIs * fix sample app compile issue * clean up logs, remove AEP prefix * remove AEP prefix for Log tags * remove AEP prefix from PriavacyStatus const strings * fix compile failure * Remove AEP prefix for internal constant strings. Co-authored-by: Calise Cheung <[email protected]> Co-authored-by: Shivam Tomar <[email protected]> Co-authored-by: Pravin Prakash Kumar <[email protected]> Co-authored-by: Emilia Dobrin <[email protected]> Co-authored-by: Emilia Dobrin <[email protected]>
* UserProfile (1.0.0-alpha.3) -> staging (#50) (#51) * UserProfile (1.0.0-alpha.3) -> staging (#50) (#53) * Edge (1.0.0-alpha.2), Messaging (1.0.0-alpha.2) -> staging (#54) * quick fix for peerDependecies issue * update sample app dependencies to latest versions * Update Edge Wrapper Readme Update Edge Wrapper Readme * update readme update readme * Edge (1.0.0-alpha.2), Messaging (1.0.0-alpha.2) -> main (#55) * EdgeIdentity (1.0.0-alpha.2) -> staging (#59) * fix a typo in readme (#61) fix a typo in readme * EdgeIdentity (1.0.0-alpha.2) -> main (#62) * add a new API in Core - resetIdentities (#63) (#64) * add a new API in Core -? resetIdentities * update core package version to alpha.2 * Update README.md * Core (1.0.0-alpha.2) -> main (#65) * add a FAQ section (#66) * Consent package setup * update dependencies * Fix consent module * Add consent to iOS sample app * Renaming, update dependencies * Update gradle * Added APIs for Consent extension (#80) * Consent - add Android + JS APIs, update sample app * Consent - sample app styling * Consent - iOS API updates, update examples on sample app * Consent - update typescript def and tests * Consent - update documentation * Consent - docs updates * Consent - reject with AEPError * Consent - add to main readme * Consent - review update sample app * fix the release issue: NPM registry enforces a minimum of TLS 1.2 beginning October 4, 2021 (#73) * Consent - renaming public JS classes (#93) * Consent - renaming for consistency with native classes * Consent - AEP renaming * Consent - updated return promise * Pods update * Core - renaming public JS classes (#102) * add a new API in Core - resetIdentities (#63) * add a new API in Core -? resetIdentities * update core package version to alpha.2 * Merge latest staging changes (#85) * EdgeIdentity (1.0.0-alpha.2) -> main (#62) * add a new API in Core -? resetIdentities * update core package version to alpha.2 * add a new API in Core - resetIdentities (#63) (#64) * add a new API in Core -? resetIdentities * update core package version to alpha.2 * Update README.md * add a FAQ section (#66) * fix the release issue: NPM registry enforces a minimum of TLS 1.2 beginning October 4, 2021 (#73) * Reduce visibility for utility classes and handle error callback (#86) * EdgeIdentity (1.0.0-alpha.2) -> main (#62) * add a new API in Core -? resetIdentities * update core package version to alpha.2 * add a new API in Core - resetIdentities (#63) (#64) * add a new API in Core -? resetIdentities * update core package version to alpha.2 * Update README.md * add a FAQ section (#66) * fix the release issue: NPM registry enforces a minimum of TLS 1.2 beginning October 4, 2021 (#73) * reduce visibility for utility classes. * handle error callback * address review comments * Core - renaming public APIs (#91) * EdgeIdentity (1.0.0-alpha.2) -> main (#62) * add a new API in Core -? resetIdentities * update core package version to alpha.2 * add a new API in Core - resetIdentities (#63) (#64) * add a new API in Core -? resetIdentities * update core package version to alpha.2 * Update README.md * add a FAQ section (#66) * fix the release issue: NPM registry enforces a minimum of TLS 1.2 beginning October 4, 2021 (#73) * reduce visibility for utility classes. * handle error callback * rename public APIs * fix sample app compile issue * clean up logs, remove AEP prefix * remove AEP prefix for Log tags * remove AEP prefix from PriavacyStatus const strings * fix compile failure * Remove AEP prefix for internal constant strings. * rename js classes * Core - clean up the sample app (#107) * add a new API in Core - resetIdentities (#63) * add a new API in Core -? resetIdentities * update core package version to alpha.2 * Merge latest staging changes (#85) * EdgeIdentity (1.0.0-alpha.2) -> main (#62) * add a new API in Core -? resetIdentities * update core package version to alpha.2 * add a new API in Core - resetIdentities (#63) (#64) * add a new API in Core -? resetIdentities * update core package version to alpha.2 * Update README.md * add a FAQ section (#66) * fix the release issue: NPM registry enforces a minimum of TLS 1.2 beginning October 4, 2021 (#73) * Reduce visibility for utility classes and handle error callback (#86) * EdgeIdentity (1.0.0-alpha.2) -> main (#62) * add a new API in Core -? resetIdentities * update core package version to alpha.2 * add a new API in Core - resetIdentities (#63) (#64) * add a new API in Core -? resetIdentities * update core package version to alpha.2 * Update README.md * add a FAQ section (#66) * fix the release issue: NPM registry enforces a minimum of TLS 1.2 beginning October 4, 2021 (#73) * reduce visibility for utility classes. * handle error callback * address review comments * Core - renaming public APIs (#91) * EdgeIdentity (1.0.0-alpha.2) -> main (#62) * add a new API in Core -? resetIdentities * update core package version to alpha.2 * add a new API in Core - resetIdentities (#63) (#64) * add a new API in Core -? resetIdentities * update core package version to alpha.2 * Update README.md * add a FAQ section (#66) * fix the release issue: NPM registry enforces a minimum of TLS 1.2 beginning October 4, 2021 (#73) * reduce visibility for utility classes. * handle error callback * rename public APIs * fix sample app compile issue * clean up logs, remove AEP prefix * remove AEP prefix for Log tags * remove AEP prefix from PriavacyStatus const strings * fix compile failure * Remove AEP prefix for internal constant strings. * Core - clean up the sample app (#106) * Core - renaming public JS classes (#102) * add a new API in Core - resetIdentities (#63) * add a new API in Core -? resetIdentities * update core package version to alpha.2 * Merge latest staging changes (#85) * EdgeIdentity (1.0.0-alpha.2) -> main (#62) * add a new API in Core -? resetIdentities * update core package version to alpha.2 * add a new API in Core - resetIdentities (#63) (#64) * add a new API in Core -? resetIdentities * update core package version to alpha.2 * Update README.md * add a FAQ section (#66) * fix the release issue: NPM registry enforces a minimum of TLS 1.2 beginning October 4, 2021 (#73) * Reduce visibility for utility classes and handle error callback (#86) * EdgeIdentity (1.0.0-alpha.2) -> main (#62) * add a new API in Core -? resetIdentities * update core package version to alpha.2 * add a new API in Core - resetIdentities (#63) (#64) * add a new API in Core -? resetIdentities * update core package version to alpha.2 * Update README.md * add a FAQ section (#66) * fix the release issue: NPM registry enforces a minimum of TLS 1.2 beginning October 4, 2021 (#73) * reduce visibility for utility classes. * handle error callback * address review comments * Core - renaming public APIs (#91) * EdgeIdentity (1.0.0-alpha.2) -> main (#62) * add a new API in Core -? resetIdentities * update core package version to alpha.2 * add a new API in Core - resetIdentities (#63) (#64) * add a new API in Core -? resetIdentities * update core package version to alpha.2 * Update README.md * add a FAQ section (#66) * fix the release issue: NPM registry enforces a minimum of TLS 1.2 beginning October 4, 2021 (#73) * reduce visibility for utility classes. * handle error callback * rename public APIs * fix sample app compile issue * clean up logs, remove AEP prefix * remove AEP prefix for Log tags * remove AEP prefix from PriavacyStatus const strings * fix compile failure * Remove AEP prefix for internal constant strings. * Clean up the sample app after renaming JS classes in Core plugin * Update the sample app Co-authored-by: Calise Cheung <[email protected]> Co-authored-by: Shivam Tomar <[email protected]> Co-authored-by: Pravin Prakash Kumar <[email protected]> Co-authored-by: Emilia Dobrin <[email protected]> Co-authored-by: Emilia Dobrin <[email protected]>
* commit '4e9dc6c5a8403f29bdcd87195b12faff6c69f6b0': (26 commits) Core - clean up the sample app (#107) Core - renaming public JS classes (#102) Pods update Consent - updated return promise Consent - renaming public JS classes (#93) fix the release issue: NPM registry enforces a minimum of TLS 1.2 beginning October 4, 2021 (#73) Added APIs for Consent extension (#80) Update gradle Renaming, update dependencies Add consent to iOS sample app Fix consent module update dependencies Consent package setup add a FAQ section (#66) Core (1.0.0-alpha.2) -> main (#65) Update README.md add a new API in Core - resetIdentities (#63) (#64) EdgeIdentity (1.0.0-alpha.2) -> main (#62) fix a typo in readme (#61) EdgeIdentity (1.0.0-alpha.2) -> staging (#59) ... # Conflicts: # apps/AEPSampleApp/App.js
* commit 'f4a283d399e78a2eb5cebd8c1c96fb302b16bc94': (88 commits) feat: convert all packages to typescript (#146) Update README.md Update README.md Edge Beta.2 release (#150) Remove unused writeableMap for EdgeIdentity convert data to WritableMap when passing it to javascript (#149) Add List Array check for Writeable Map in Utils files Change checking the instanceof List instead of the ArrayList Remove unused flow library definition files (#135) Add ArrayList check for more locations. Add Arraylist support in WriteableArray Add registering extensions example in UserProfile README (#142) fix heading style for API names (#140) Update API reference for Core & Profile extensions (#138) Add a migration doc for ACP library users (#137) Remove Jcenter() repository from Gradle file (#134) clean up README Staging -> main for beta.1 release (#129) Bug fix: correct error handling logic (#133) REAME cleanup (#132) ... # Conflicts: # apps/AEPSampleApp/App.tsx # apps/AEPSampleApp/extensions/Profile.js # apps/AEPSampleApp/extensions/ProfileView.js # apps/AEPSampleApp/extensions/ProfileView.tsx # packages/userprofile/README.md # packages/userprofile/__tests__/UserProfileTests.ts # packages/userprofile/js/AEPUserProfile.js # packages/userprofile/js/index.d.ts # packages/userprofile/js/index.js # packages/userprofile/ts/UserProfile.js # packages/userprofile/ts/UserProfile.ts # yarn.lock
cacheung
reviewed
Mar 22, 2022
|
|
||
| ```javascript | ||
| ```typescript | ||
| UserProfile.extensionVersion().then(version => console.log("AdobeExperienceSDK: UserProfile version: " + version)); |
Contributor
There was a problem hiding this comment.
Should we change double quote to single quote for ts
' '
cacheung
approved these changes
Mar 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.