Skip to content

Conversation

@yangyansong-adbe
Copy link
Contributor

Description

Related Issue

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • I have signed the Adobe Open Source CLA.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

* Initialize project

* Add TypeScript declaration files for Core/UserProfile (#10)

* Project cleanup  (#12)
Copy link
Contributor

@cacheung cacheung left a comment

initializeFlipper(this, getReactNativeHost().getReactInstanceManager());
MobileCore.setApplication(this);
MobileCore.setLogLevel(LoggingMode.DEBUG);
try {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add after this setLogLevel
//MobileCore.configureWithAppID("yourAppID");
as a reference for user to add app id?

}

google()
jcenter()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add
mavenCentral()

// Empty.swift
// AEPSampleApp
//
// Created by Yansong Yang on 6/29/21.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you want to leave your name here?

rootViewController.view = rootView;
self.window.rootViewController = rootViewController;
[self.window makeKeyAndVisible];
[AEPMobileCore setLogLevel: AEPLogLevelTrace];
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to change to Debug level?

[AEPMobileCore setLogLevel: AEPLogLevelTrace];
[AEPMobileCore registerExtensions: @[AEPMobileIdentity.class, AEPMobileLifecycle.class, AEPMobileSignal.class, AEPMobileUserProfile.class] completion:^{
[AEPMobileCore lifecycleStart:@{@"contextDataKey": @"contextDataVal"}];
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add below for reference?
//[AEPMobileCore configureWithAppId:@"yourAppID"];

@yangyansong-adbe
Copy link
Contributor Author

@cacheung addressed your comments in another PR #15

yangyansong-adbe added a commit to yangyansong-adbe/aepsdk-react-native that referenced this pull request Aug 25, 2021
* commit '250fd069e9801aa01c3dea0991dfb792bd2bf7e3':
  Fix CI (out-of-memory) failure (adobe#18)
  Update package.json
  Update npm-publish.yml
  Add release script (adobe#17)
  Update README.md (adobe#16)
  more project cleanup  (adobe#15)
  Init project (adobe#14)

# Conflicts:
#	.gitignore
#	README.md
#	apps/AEPSampleApp/android/app/src/main/java/com/aepsampleapp/MainActivity.java
#	apps/AEPSampleApp/android/app/src/main/java/com/aepsampleapp/MainApplication.java
#	apps/AEPSampleApp/android/build.gradle
#	apps/AEPSampleApp/android/gradle.properties
#	apps/AEPSampleApp/ios/AEPSampleApp/AppDelegate.h
#	apps/AEPSampleApp/ios/AEPSampleApp/AppDelegate.m
#	apps/AEPSampleApp/ios/AEPSampleApp/Empty.swift
#	apps/AEPSampleApp/ios/AEPSampleApp/main.m
#	apps/AEPSampleApp/ios/AEPSampleAppTests/AEPSampleAppTests.m
#	apps/AEPSampleApp/package.json
#	package.json
#	packages/core/package.json
#	packages/userprofile/package.json
#	yarn.lock
yangyansong-adbe added a commit to yangyansong-adbe/aepsdk-react-native that referenced this pull request Aug 26, 2021
* commit 'a6776050d3d7dff8ec244d431174f522de40e605':
  Update README.md
  Update README.md
  typo
  fix android app launching issue
  Create README.md
  Update badges on readme
  bump version (adobe#21) (adobe#23)
  bump version (adobe#20)
  remove user data
  Fix CI (out-of-memory) failure (adobe#18)
  Update package.json
  Update npm-publish.yml
  Add release script (adobe#17)
  Update README.md (adobe#16)
  more project cleanup  (adobe#15)
  Init project (adobe#14)
yangyansong-adbe added a commit that referenced this pull request Aug 26, 2021
* commit 'a6776050d3d7dff8ec244d431174f522de40e605':
  Update README.md
  Update README.md
  typo
  fix android app launching issue
  Create README.md
  Update badges on readme
  bump version (#21) (#23)
  bump version (#20)
  remove user data
  Fix CI (out-of-memory) failure (#18)
  Update package.json
  Update npm-publish.yml
  Add release script (#17)
  Update README.md (#16)
  more project cleanup  (#15)
  Init project (#14)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants