remove common_hal_pwmio_pwmout_never_reset and remaining pwmout_reset #8991
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tannewt
requested changes
Feb 29, 2024
Member
tannewt
left a comment
tannewt
left a comment
There was a problem hiding this comment.
Sorry for misleading you on this. I think we do need the indirect pin never_reset calls. We can remove these once the blanket pin reset is removed too.
|
|
||
|
|
||
| void common_hal_pwmio_pwmout_never_reset(pwmio_pwmout_obj_t *self) { | ||
| never_reset_pin_number(self->pin->number); |
Member
There was a problem hiding this comment.
This is why we still need this. Or at least, we need to replace the pwm never_reset with pin never_reset.
Collaborator
Author
|
Since this is innocuous, and we probably don't want to do the pin never-reset removal for 9.0.0, I can make this a draft and mark it 9.x.x. |
Collaborator
Author
|
Closing in favor of issue #8960. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finishes remaining needed removals from #8966 and #8990 (comment), and some other unused code.
Retested #8985 on MEMENTO: no regression.