Switch to finaliser for PWMOut and audiopwmio #8966
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes micropython#8726 which was caused by a mix of bulk reset and finaliser use. Work towards micropython#8960.
dhalbert
requested changes
Feb 21, 2024
Collaborator
dhalbert
left a comment
dhalbert
left a comment
There was a problem hiding this comment.
Various build failures in atmel-samd and raspberrypi due to now-missing routines.
Member
Author
|
Builds are fixed @dhalbert |
Collaborator
|
Thanks! I will do some hw testing a little later. |
dhalbert
approved these changes
Feb 22, 2024
Collaborator
dhalbert
left a comment
dhalbert
left a comment
There was a problem hiding this comment.
Tested on an RP2040, creating some PWMOuts and then restarting the VM. Things seem fine. I'm impressed the code has gotten smaller!
This was referenced Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8726 which was caused by a mix of bulk reset and finaliser use.
Work towards #8960.