Skip to content

Conversation

@johnrbnsn
Copy link
Contributor

I have a v3HP, so I added support for this sensor (via sensor_type parameter which defaults to v3). They have a slightly different read method and status checking, as well as some slightly different registers. The registers I added are either common to the v3 and v3HP, or have a check for the sensor type before returning any values.

@FoamyGuy
Copy link
Contributor

@johnrbnsn thanks for working on this! The actions check failed due to code formatting.

The easiest way to run it is to do all the checks at once with pre-commit. We have a documentation page here: https://learn.adafruit.com/creating-and-sharing-a-circuitpython-library/check-your-code that show show.

Black is the specific code format we use, it's documented on another page in that learn guide: https://learn.adafruit.com/creating-and-sharing-a-circuitpython-library/black

If you have any trouble I can help out, there are more folks on our discord who can help as well if you want to join us there.

@johnrbnsn
Copy link
Contributor Author

Thanks, I'll take a look and try to get it formatted properly!

Copy link
Contributor

@FoamyGuy FoamyGuy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks for extending this library to support an extra type of sensor @johnrbnsn!

I don't have the specific hardware required for testing (neither V3 or V3HP). But did look over the code and everything seems in order to me.

@FoamyGuy FoamyGuy merged commit 4069536 into adafruit:main Jul 11, 2022
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Jul 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants