-
Notifications
You must be signed in to change notification settings - Fork 11
TFT Featherwing Code & BMP Examples #25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
My first EVER commit. Crossing my fingers this works.
I get credit now as a contributor. Sweet.
|
Hooray! Thank you for submitting this @DJDevon3 It looks like you've got the fork and commit / push / create PR process done correctly, so congrats on your first one 🎉 A few things to touch up with the code and added files themself though: We use Black code formatting for all of the library and example code. The easiest way to do it is to run all of the same checks that we do automatically on github at once using a tool called Specifically this PR did not pass the check due to the code formatting (which pre-commit will take care of if you run it) as well as missing license files for the new .bmp images. All files in the repo must have a license associated with them. For image files this is a text file with the same name and You can run pre-commit and add those license files locally and then make a new commit and push to this branch and it should automatically show up here in the PR and trigger the checks to re-run again. Let me know if you have any issues I or someone on our discord will be able to help you work through them. Thanks again. |
Attempted to install pre-commit, unsure if it was successful.
fixed according to github pylint recommendations
FoamyGuy
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made a few small tweaks:
Removed I2C bus initialization. It wasn't used by the rest of the script, and in cases where the user has no other devices connected to the bus it can raise an exception (this occurred to me during testing).
Added display.release_displays() before initializing the external display. This is typically best practice with external displays. If not done it can cause trouble if the user attempts to run the same script a second (or more) times.
Removed a comment about 2.5" featherwing device. The closest one I could find on adafruit.com was 2.4" and it uses a different driver so it would require a different import and display initialization code in order to be supported. It could be added later commented out if someone would like to.
I tested the example from this PR with these tweaks successfully on a Feather RP2040 with 3.5" TFT Featherwing.
Thanks again for submitting this @DJDevon3
Updating https://github.com/adafruit/Adafruit_CircuitPython_LIDARLite to 1.3.0 from 1.2.10: > Merge pull request adafruit/Adafruit_CircuitPython_LIDARLite#20 from johnrbnsn/main Updating https://github.com/adafruit/Adafruit_CircuitPython_BitmapSaver to 1.2.4 from 1.2.3: > Merge pull request adafruit/Adafruit_CircuitPython_BitmapSaver#25 from DJDevon3/local
My first EVER commit. Crossing my fingers this works.