Skip to content

Remove unused interrupt pin arg and doc updates #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Nov 5, 2021
Merged

Remove unused interrupt pin arg and doc updates #34

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
ef76b97
Removed unused interrupt_pin arg
fivesixzero Nov 4, 2021
7020e37
Doc updates
fivesixzero Nov 4, 2021
98749fb
Removed unused interrupt_pin arg (docs and examples)
fivesixzero Nov 4, 2021
2dae155
Removed unused interrupt_pin arg (update)
fivesixzero Nov 4, 2021
051e996
Removed unused interrupt_pin arg (making linters happy)
fivesixzero Nov 4, 2021
ef02f6e
Doc updates (typo fix)
fivesixzero Nov 4, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions README.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ Usage Example

i2c = board.I2C()
int_pin = digitalio.DigitalInOut(board.D5)
apds = APDS9960(i2c, interrupt_pin=int_pin)
apds = APDS9960(i2c)

apds.enable_proximity = True
apds.proximity_interrupt_threshold = (0, 175)
Expand Down Expand Up @@ -99,7 +99,7 @@ pin for proximity detection.

int_pin = digitalio.DigitalInOut(board.A1)
i2c = board.I2C()
apds = APDS9960(i2c, interrupt_pin=int_pin)
apds = APDS9960(i2c)

Gestures
--------
Expand Down
25 changes: 11 additions & 14 deletions adafruit_apds9960/apds9960.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,15 @@
* Adafruit `APDS9960 Proximity, Light, RGB, and Gesture Sensor
<https://www.adafruit.com/product/3595>`_ (Product ID: 3595)

* Adafruit `Adafruit CLUE
<https://www.adafruit.com/product/4500>`_ (Product ID: 4500)

* Adafruit `Adafruit Feather nRF52840 Sense
<https://www.adafruit.com/product/4516>`_ (Product ID: 4516)

* Adafruit `Adafruit Proximity Trinkey
<https://www.adafruit.com/product/5022>`_ (Product ID: 5022)

**Software and Dependencies:**

* Adafruit CircuitPython firmware for the supported boards:
Expand All @@ -27,7 +36,6 @@
* Adafruit's Bus Device library: https://github.com/adafruit/Adafruit_CircuitPython_BusDevice
"""
import time
import digitalio
from adafruit_register.i2c_bits import RWBits
from adafruit_register.i2c_bit import RWBit
from adafruit_bus_device.i2c_device import I2CDevice
Expand Down Expand Up @@ -97,8 +105,7 @@ class APDS9960:
"""
APDS9900 provide basic driver services for the ASDS9960 breakout board

:param ~busio.I2C i2c: The I2C bus the BME280 is connected to
:param ~microcontroller.Pin interrupt_pin: Interrupt pin. Defaults to `None`
:param ~busio.I2C i2c: The I2C bus the ASDS9960 is connected to
:param int address: The I2C device address. Defaults to :const:`0x39`
:param int integration_time: integration time. Defaults to :const:`0x01`
:param int gain: Device gain. Defaults to :const:`0x01`
Expand Down Expand Up @@ -136,23 +143,13 @@ class APDS9960:
_proximity_persistance = RWBits(4, APDS9960_PERS, 4)

def __init__(
self,
i2c,
*,
interrupt_pin=None,
address=0x39,
integration_time=0x01,
gain=0x01,
rotation=0
self, i2c, *, address=0x39, integration_time=0x01, gain=0x01, rotation=0
):

self.buf129 = None
self.buf2 = bytearray(2)

self.i2c_device = I2CDevice(i2c, address)
self._interrupt_pin = interrupt_pin
if interrupt_pin:
self._interrupt_pin.switch_to_input(pull=digitalio.Pull.UP)

if self._read8(APDS9960_ID) != 0xAB:
raise RuntimeError()
Expand Down
2 changes: 1 addition & 1 deletion examples/apds9960_proximity_simpletest.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@

i2c = board.I2C()
int_pin = digitalio.DigitalInOut(board.D5)
apds = APDS9960(i2c, interrupt_pin=int_pin)
apds = APDS9960(i2c)

apds.enable_proximity = True
apds.proximity_interrupt_threshold = (0, 175)
Expand Down