Remove unused interrupt pin arg and doc updates #34
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
Should be ready for review now that I've tidied up the typos and linter errors. :) |
Author
|
For good measure I double-checked the APDS9960 Learn Guide CircuitPython page. The interrupt features aren't mentioned in there and the examples don't make use of the |
askpatrickw
approved these changes
Nov 5, 2021
askpatrickw
left a comment
askpatrickw
left a comment
There was a problem hiding this comment.
Did not test, but these changes look to be sound based on the conversation and the notes in the original Issue.
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Nov 14, 2021
Updating https://github.com/adafruit/Adafruit_CircuitPython_APDS9960 to 2.2.8 from 2.2.7: > Merge pull request adafruit/Adafruit_CircuitPython_APDS9960#36 from fivesixzero/type-annotations > Updated readthedocs file > Merge pull request adafruit/Adafruit_CircuitPython_APDS9960#34 from fivesixzero/remove-unused-interrupt-pin-arg > Disabled unspecified-encoding pylint check > Merge pull request adafruit/Adafruit_CircuitPython_APDS9960#35 from adafruit/patch-test > add docs link to readme > Globally disabled consider-using-f-string pylint check > Moved default branch to main > Moved CI to Python 3.7 > Added help text and problem matcher > Added pull request template Updating https://github.com/adafruit/Adafruit_CircuitPython_AirLift to 1.0.2 from 1.0.1: > Merge pull request adafruit/Adafruit_CircuitPython_AirLift#6 from tekktrik/feature/add-typing > Updated readthedocs file > Disabled unspecified-encoding pylint check > PATCH Pylint and readthedocs patch test > add docs link to readme > Globally disabled consider-using-f-string pylint check > Moved CI to Python 3.7 > Added help text and problem matcher > Added pull request template > "Increase duplicate code check threshold "
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #33 with some minor doc updates for good measure.
These changes don't have any effect on the example code or the function of the library. The only thing that the incoming
interrupt_pinarg used to do was to set an internal variable that was never actually used.An alternative approach would be to update the doc to indicate that we want a
DigtalInOutrather than aPin. Given that it isn't used, I've started with this PR. Feel free to reject the PR if this approach isn't appropriate. :)