Skip to content

LorisForm updates: Dates (addGroupRule) and deprecated registerRule() #2392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Nov 2, 2016
Merged

LorisForm updates: Dates (addGroupRule) and deprecated registerRule() #2392

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5b0f616
Update to Sample Instrument : LorisForm Dates
christinerogers Nov 1, 2016
f7e4349
also removing deprecated registerRule()
christinerogers Nov 2, 2016
2898d8b
Reliability: removing deprecated registerRule()
christinerogers Nov 2, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions docs/instruments/NDB_BVL_Instrument_radiology_review.class.inc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,9 +104,8 @@ class NDB_BVL_Instrument_radiology_review extends NDB_BVL_Instrument
$examiners = $this->_getExaminerNames();
$this->form->addElement('select', 'Examiner', 'Radiologist', $examiners);

$this->form->addGroupRule('Date_taken', 'Date of Administration is required', 'required');
$this->form->addRule('Date_taken', 'Date of Administration is required', 'required');

$this->form->registerRule('checkdate', 'callback', '_checkDate');
$this->form->addRule('Date_taken', 'Date of Administration is invalid', 'checkdate');

$this->form->addRule('Examiner', 'Examiner is required', 'required');
Expand Down
2 changes: 0 additions & 2 deletions php/libraries/NDB_Reliability.class.inc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -381,8 +381,6 @@ class NDB_Reliability extends NDB_Form
$examiners = $this->_getExaminerNames();
$this->addSelect('Examiner', 'Reliability Coder', $examiners);

$this->form->registerRule('checkdate', 'callback', '_checkDate');

$this->addSelect(
'invalid',
'<font color="red">Mark as invalid</font>',
Expand Down