LorisForm updates: Dates (addGroupRule) and deprecated registerRule() #2392
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
christinerogers
added
Category: Bug
jstirling91
previously requested changes
Nov 1, 2016
| $this->form->addGroupRule('Date_taken', 'Date of Administration is required', 'required'); | ||
| $this->form->addRule('Date_taken', 'Date of Administration is required', 'required'); | ||
|
|
||
| $this->form->registerRule('checkdate', 'callback', '_checkDate'); |
There was a problem hiding this comment.
this function is deprecated, just remove the call
jstirling91
added
State: Needs work
christinerogers
added
Request Code Review
and removed
State: Needs work
christinerogers
changed the title
driusan
dismissed
jstirling91’s stale review
Jordan says these changes have been done
driusan
approved these changes
Nov 2, 2016
driusan
removed
Release: Breaking changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR cleans up all instances of dates using addGroupRule, and registerRule() deprecated function calls in the codebase.
Updated sample Radiology Review instrument in docs/ :
NDB_Reliability update: