- 
                Notifications
    You must be signed in to change notification settings 
- Fork 186
[instrument_list] Translates Instrument list module. #10033
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
          
     Merged
      
      
            driusan
  merged 6 commits into
  aces:main
from
racostas:2025_09_28_multilingual_instrument_list_translation
  
      
      
   
  Oct 17, 2025 
      
    
                
     Merged
            
            [instrument_list] Translates Instrument list module. #10033
                    driusan
  merged 6 commits into
  aces:main
from
racostas:2025_09_28_multilingual_instrument_list_translation
  
      
      
   
  Oct 17, 2025 
              
            Conversation
  
    
      This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
      Learn more about bidirectional Unicode characters
    
  
  
    
    
      
  
    Contributor
      
  
  
         racostas
  
      
      
      commented
      
            racostas
  
      
      
      commented
        Sep 29, 2025 
      
    
  
- Translates Instrument list module
- Spanish language was use for demonstration purposes only. ( Also the only Spanish translations included in the loris.po file were the ones used in this module -- for simplicity and speeding the process)
- some entries were added to the general loris.pot file since they are used in other modules as well.
- Breadcrumb are not translated in this PR since they came from other two modules candidate_list and candidate_profile respectively
              
                    driusan
  
              
              reviewed
              
                  
                    Sep 29, 2025 
                  
              
              
            
            
              
                    driusan
  
              
              reviewed
              
                  
                    Sep 29, 2025 
                  
              
              
            
            
              
                    driusan
  
              
              reviewed
              
                  
                    Sep 29, 2025 
                  
              
              
            
            
              
                    driusan
  
              
              reviewed
              
                  
                    Oct 16, 2025 
                  
              
              
            
            
              
                    driusan
  
              
              reviewed
              
                  
                    Oct 16, 2025 
                  
              
              
            
            
              
                    driusan
  
              
              reviewed
              
                  
                    Oct 17, 2025 
                  
              
              
            
            
| The "Imaging Scan Done" column in the header is showing "Y" or "N" instead of the translated "Yes" or "No" string. I adapted this patch from the timepoint list to fix it:  | 
    
  driusan 
      added a commit
      that referenced
      this pull request
    
      Oct 20, 2025 
    
    
      
  
    
      
    
  
Adds machine generated translation strings for Japanese for the new template strings from #10033, so that we have one language which is fully up to date.
  
    Sign up for free
    to join this conversation on GitHub.
    Already have an account?
    Sign in to comment
  
      Labels
      
    Language: PHP
  PR or issue that update PHP code 
  
    Module: instrument_list
  PR or issue related to instrument_list module 
  
    Module: timepoint_list
  PR or issue related to the timepoint_list module 
  
    Multilingual
  Any tasks related to making LORIS multilingual 
  Add this suggestion to a batch that can be applied as a single commit.
  This suggestion is invalid because no changes were made to the code.
  Suggestions cannot be applied while the pull request is closed.
  Suggestions cannot be applied while viewing a subset of changes.
  Only one suggestion per line can be applied in a batch.
  Add this suggestion to a batch that can be applied as a single commit.
  Applying suggestions on deleted lines is not supported.
  You must change the existing code in this line in order to create a valid suggestion.
  Outdated suggestions cannot be applied.
  This suggestion has been applied or marked resolved.
  Suggestions cannot be applied from pending reviews.
  Suggestions cannot be applied on multi-line comments.
  Suggestions cannot be applied while the pull request is queued to merge.
  Suggestion cannot be applied right now. Please check back later.