Skip to content

Conversation

@racostas
Copy link
Contributor

  • Translates Instrument list module
  • Spanish language was use for demonstration purposes only. ( Also the only Spanish translations included in the loris.po file were the ones used in this module -- for simplicity and speeding the process)
  • some entries were added to the general loris.pot file since they are used in other modules as well.
  • Breadcrumb are not translated in this PR since they came from other two modules candidate_list and candidate_profile respectively

@github-actions github-actions bot added Language: PHP PR or issue that update PHP code Module: instrument_list PR or issue related to instrument_list module Module: timepoint_list PR or issue related to the timepoint_list module labels Sep 29, 2025
@racostas racostas linked an issue Sep 29, 2025 that may be closed by this pull request
@racostas racostas added the Multilingual Any tasks related to making LORIS multilingual label Sep 29, 2025
@racostas racostas requested a review from driusan September 29, 2025 19:44
@racostas racostas requested a review from driusan October 17, 2025 13:04
@driusan
Copy link
Collaborator

driusan commented Oct 17, 2025

The "Imaging Scan Done" column in the header is showing "Y" or "N" instead of the translated "Yes" or "No" string.

I adapted this patch from the timepoint list to fix it:

diff --git a/modules/instrument_list/templates/menu_instrument_list.tpl b/modules/instrument_list/templates/menu_instrument_list.tpl
index ca0770747..46992abec 100644
--- a/modules/instrument_list/templates/menu_instrument_list.tpl
+++ b/modules/instrument_list/templates/menu_instrument_list.tpl
@@ -109,7 +109,18 @@
         {$display.CohortTitle}
       </td>
       <td>
-        {$display.Scan_done|default:"<img alt=\"Data Missing\" src=\"{$baseurl|default}/images/help2.gif\" width=\"12\" height=\"12\" />"}
+        {if $display.Scan_done != ""}
+                {if $display.Scan_done == 'Y'}
+                    {assign var="scan_done" value=dgettext("loris", "Yes")}
+                    <a href="{$baseurl|default}/imaging_browser/viewSession/?sessionID={$sessionID}" class="timepoint_list">
+                    {$scan_done}</a>
+                {else}
+                    {assign var="scan_done" value={dgettext("loris", "No")}}
+                    {$scan_done}
+                {/if}
+        {else}
+            <img alt="Data Missing" src="{$baseurl|default}/images/help2.gif" border=0>
+        {/if}
       </td>
       <td>
         {if $display.WindowInfo.Optimum|default}

@driusan driusan merged commit 6a868b2 into aces:main Oct 17, 2025
20 checks passed
driusan added a commit that referenced this pull request Oct 20, 2025
Adds machine generated translation strings for Japanese for the new
template strings from #10033, so that we have one language which is
fully up to date.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Language: PHP PR or issue that update PHP code Module: instrument_list PR or issue related to instrument_list module Module: timepoint_list PR or issue related to the timepoint_list module Multilingual Any tasks related to making LORIS multilingual

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[instrument_list] Multilingual Support

3 participants