Skip to content

[my_preferences] Translate to my_preferences module #10015

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

[my_preferences] Translate to my_preferences module #10015

wants to merge 10 commits into from

Conversation

@SKADE2303
Copy link
Collaborator

This PR is responsible for translating the module my_preferences to different languages. Currently only 'Hindi' language is supported but other languages can be added as required.

Testing instructions (if applicable)

  1. Run 'make dev' to load changes
  2. Change language_preference to Hindi in my_preferences Tab
  3. Go to my_preferences tab to see translated web page.

@SKADE2303 SKADE2303 added Module: my_preferences PR or issue related to my_preferences module Event: GSOC PR or issue accepted for Google Summer of Code Multilingual Any tasks related to making LORIS multilingual labels Sep 15, 2025
@SKADE2303 SKADE2303 requested a review from racostas September 15, 2025 14:04
@racostas racostas self-assigned this Sep 15, 2025
racostas
racostas requested changes Sep 16, 2025
View reviewed changes
Copy link
Contributor

@racostas racostas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @SKADE2303 , as requested in #10009
Save and Reset should be in loris.po ns not in the module itself since this two worlds are used all across the LORIS system. Thank you.

@racostas racostas added the State: Needs work PR awaiting additional work by the author to proceed label Sep 16, 2025
@racostas
Copy link
Contributor

There are also missing translations
image

@github-actions github-actions bot added the Language: PHP PR or issue that update PHP code label Sep 19, 2025
@SKADE2303 SKADE2303 force-pushed the TranslateMyPreferences branch from 2509634 to 41d56c4 Compare September 19, 2025 12:10
@racostas
Copy link
Contributor

@SKADE2303 , automatic tests still failing here.

@racostas racostas added the State: Needs rebase PR that needs to be rebased to proceed (conflicts, wrong branch...) label Sep 29, 2025
@racostas
Copy link
Contributor

Conflicts need to be resolved. Needs rebase. Also the test that are failing here does are related to this PR.
image

@SKADE2303 SKADE2303 force-pushed the TranslateMyPreferences branch from 49c7b3a to c0e0aa5 Compare September 29, 2025 11:14
@driusan driusan mentioned this pull request Sep 29, 2025
Open
@racostas
Copy link
Contributor

Is this one ready to be re-reviewed ?
Also the unrelated text failing are fixed already. Please relaunch the tests.

@racostas racostas self-requested a review September 30, 2025 14:56
racostas
racostas requested changes Sep 30, 2025
View reviewed changes
Copy link
Contributor

@racostas racostas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume it's not ready yet.

There are some missing translations:
image

@kongtiaowang kongtiaowang reopened this Sep 30, 2025
@SKADE2303 SKADE2303 force-pushed the TranslateMyPreferences branch 3 times, most recently from 0e4263c to 5a04f4f Compare October 1, 2025 14:01
@racostas
Copy link
Contributor

racostas commented Oct 6, 2025

Test still failing here. Please re-launch / fix.

@SKADE2303 SKADE2303 force-pushed the TranslateMyPreferences branch from 423154c to 0feec63 Compare October 7, 2025 22:28
@SKADE2303 SKADE2303 force-pushed the TranslateMyPreferences branch from b147cc2 to 6321cd0 Compare October 21, 2025 12:45
@christinerogers
Copy link
Contributor

resolves #9804

@christinerogers christinerogers added the State: Blocking PR should be prioritized because it is blocking the progress of another task label Oct 21, 2025
@SKADE2303 SKADE2303 removed State: Needs rebase PR that needs to be rebased to proceed (conflicts, wrong branch...) State: Needs work PR awaiting additional work by the author to proceed labels Oct 21, 2025
@racostas racostas linked an issue Oct 22, 2025 that may be closed by this pull request
[my_preferences] Multilingual Support #9804
Open
@racostas racostas self-requested a review October 23, 2025 14:17
@racostas
Copy link
Contributor

There are missing translations in the PR that was already requested in SEP 16th
image

@SKADE2303 , please manual test the PR in your end and go over the comments before sending back to test for us. Thanks you.

@christinerogers @driusan

@racostas racostas added the State: Needs work PR awaiting additional work by the author to proceed label Oct 23, 2025
racostas
racostas requested changes Oct 23, 2025
View reviewed changes
Copy link
Contributor

@racostas racostas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change don't seems to be consistent. The key in the .pot and the .po files are different.

image

@racostas
Copy link
Contributor

More untranslated words, again please carefully test.
image

racostas
racostas reviewed Oct 23, 2025
View reviewed changes
modules/my_preferences/locale/my_preferences.pot Outdated
Comment on lines 48 to 68
msgid "User name"
msgstr ""

msgid "First name"
msgstr ""

msgid "First name is required and should not exceed 120 characters"
msgstr ""

msgid "Last name"
msgstr ""

msgid "Last name is required and should not exceed 120 characters"
msgstr ""

msgid "Email address"
msgstr ""

msgid "Email address is required"
msgstr ""

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are lot of terms here that are common with user_account, please put all that is common in loris.pot/ loris.po and use this in both modules: my_preferences and user_account

For reference this is the user_account PR #9934

@racostas
Copy link
Contributor

this PR is blocking #9934 since there are lot of terms in common that should be going to **loris.pot and loris.po ** in place of my_preferences locale

@racostas racostas mentioned this pull request Oct 23, 2025
Open
@SKADE2303 SKADE2303 force-pushed the TranslateMyPreferences branch from 769716d to 4d433af Compare October 26, 2025 13:44
@SKADE2303 SKADE2303 force-pushed the TranslateMyPreferences branch from 4d433af to 92257be Compare October 26, 2025 13:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@racostas racostas racostas requested changes

Requested changes must be addressed to merge this pull request.

Assignees

@racostas racostas

@SKADE2303 SKADE2303

Labels

Event: GSOC PR or issue accepted for Google Summer of Code Language: PHP PR or issue that update PHP code Module: my_preferences PR or issue related to my_preferences module Multilingual Any tasks related to making LORIS multilingual State: Blocking PR should be prioritized because it is blocking the progress of another task State: Needs work PR awaiting additional work by the author to proceed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[my_preferences] Multilingual Support

4 participants

@SKADE2303 @racostas @christinerogers @kongtiaowang