Skip to content

[Forwardport] Fix HTML syntax in report.phtml error template #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 134 commits into
base: 2.3-develop
Choose a base branch
from
Open

[Forwardport] Fix HTML syntax in report.phtml error template #1

wants to merge 134 commits into from

Conversation

@abcpremium
Copy link
Owner

@abcpremium abcpremium commented May 25, 2018

Original Pull Request

magento#15454
Added missing quotes to the div tags with class control.

Description

Added missing quotes to the class attribute of div tags in the default reporting template file in pub/errors/default/report.phtml

Fixed Issues (if relevant)

Manual testing scenarios

  1. Open in any editor with syntax highlighting, it shouldn't show any more syntax warnings.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/integration tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)

danielrenaud and others added 30 commits May 10, 2018 14:47
@danielrenaud
MAGETWO-86709: Widget isn't updated on Storefront if related Products…
8e0ff74 
… are updated
@danielrenaud
MAGETWO-89410: [2.3] Test testValidComposerJson fails on bundle exten…
7e85049 
…sions

- Backport: MAGETWO-88812: Test testValidComposerJson fails on bundle extensions
@danielrenaud
MAGETWO-86709: Widget isn't updated on Storefront if related Products…
2518b24 
… are updated
@jilu1
MC-57: Admin should be able to mass change products' status.
32a3284
@jilu1
Merge remote-tracking branch 'upstream/2.3-develop' into MC-57
bd730bc
@jilu1
MC-77: Customer should see basic Configurable Product details.
a92215a 
- Added mftf test.
@jilu1
MC-92: Customer should be able to see product configuration options.
3c825ca 
- Added mftf test.
@jilu1
MC-97: Customer should be able to successfully add the product to the…
1698e2b 
… cart.

- Added mftf test.
MAGETWO-90358: Auto-generate ExtensionAttributes object
375132a
@StasKozar
MAGETWO-90350: Admin Section is not visible in backend on production …
a73491c 
…mode - GitHub issue magento#14104
@svitja
MAGETWO-89411: [2.3] Failed Magento\Test\Integrity\ExceptionHierarchy…
028e67d 
…Test::testIsInheritedLocalizedException
@jilu1
MC-81: Customer should not be able to add the product to the cart if …
69ed26a 
…options are not selected.

- Added mftf test.
@jilu1
MC-113: Admin should be able to add and remove images for simple prod…
05af625 
…ucts.

- Updated story annotation.
MAGETWO-91450: date reverts in past after clicking out of product edit …
38c48a6 
…magento#11517

 - provided initial value for shiftedValue
@zakdma
MAGETWO-89412: [2.3] Composer static test of PHP versions is failed f…
5b92f7b 
…or non-core modules
@StasKozar
MAGETWO-90350: Admin Section is not visible in backend on production …
087cf5d 
…mode - GitHub issue magento#14104
@StasKozar
MAGETWO-90818: Files and folders symlinked in pub/media cannot be del…
d050393 
…eted from media gallery browser
@zakdma
Merge remote-tracking branch 'origin/2.3-develop' into MAGETWO-90350
14a9854
@zakdma
MAGETWO-89409: [2.3] Test Magento\Ui\Component\ConfigurationTest::tes…
6817451 
…tConfiguration failing with bundled extensions
@jilu1
MC-81: Customer should not be able to add the product to the cart if …
e2c06ce 
…options are not selected.

- Updated mftf test.
@tomreece
MC-86: Admin should be able to remove a configuration from a Configur…
ba3a3fc 
…able Product
@zakdma
Merge remote-tracking branch 'origin/2.3-develop' into MAGETWO-89409
28ffb3a
@zakdma
MAGETWO-89408: [2.3] Failed Magento\Test\Integrity\ClassesTest::testC…
060fdf6 
…lassReferences
@StasKozar
MAGETWO-90801: Can't create customer account on checkout success page…
283a799 
… when gender field is required
@DianaRusin
MAGETWO-77759: [2.3] - Related Products Rule for Up-sell Products wit…
2d37d37 
…h Customer Segments Specified Doesn't Work
@StasKozar
Merge remote-tracking branch 'origin/MAGETWO-89411' into 2.3-develop-…
1860714 
…pr19
@zakdma
MAGETWO-61364: [GitHub] Dependency check in the static tests fails fo…
dec4c87 
…r non core modules magento#7421
@zakdma
MAGETWO-89412: [2.3] Composer static test of PHP versions is failed f…
fd561ac 
…or non-core modules
@DianaRusin
Merge remote-tracking branch 'origin/2.3-develop' into MAGETWO-77759
d0b8c1d
@DianaRusin
Merge remote-tracking branch 'origin/MAGETWO-90350' into 2.3-develop-…
4e6f3e5 
…pr19
AnshuMishra17 and others added 30 commits May 23, 2018 20:10
@AnshuMishra17 @mzeis
typo correction
d56a57b
@cpartica
Merge pull request magento#2584 from magento-pangolin/RE-develop
a24105d 
[pangolin] RE-develop Functional Tests
@cpartica
Merge remote-tracking branch 'mainline/2.3-develop' into MAGETWO-9144…
3aafe9e 
…0-unassigned-attribute-n-a

# Conflicts:
#	dev/tests/acceptance/tests/functional/Magento/FunctionalTest/Catalog/Data/ProductData.xml
@zakdma
Merge remote-tracking branch 'origin/2.3-develop' into MAGETWO-89412
8b422e9 
# Conflicts:
#	dev/tests/static/testsuite/Magento/Test/Integrity/ComposerTest.php
@zakdma
Merge remote-tracking branch 'origin/MAGETWO-89412' into 2.3-develop-…
caa0d44 
…pr19
Merge pull request magento#2591 from magento-tsg/2.3-develop-pr19
af84959 
[TSG] Upporting for 2.3 (pr19) (2.3.0)
@VladimirZaets
15210-Fixed product tier pricing pagination
75960ce 
- Fix prevPage and nextPage method. Calling clear method was added to changePage method.
@magento-engcom-team
ENGCOM-1653: 15210-Fixed product tier pricing pagination issue in admin
9d2b93c 
magento#15360

 - Merge Pull Request magento#15360 from saravananvelu/magento2:admin-tierprice
 - Merged commits:
   1. cad44a3
   2. 560aa38
   3. 8a8ed66
   4. ba6bf77
   5. 6de6006
   6. ec3eb1a
   7. 75960ce
Duplicate array keys
9ebdcc5
@magento-engcom-team
ENGCOM-1661: [Forwardport] typo correction magento#15466
0627a3c 
 - Merge Pull Request magento#15466 from mzeis/magento2:2.3-develop-PR-port-15431
 - Merged commits:
   1. d56a57b
Return tag misspelled
8e14879
@cpartica
MAGETWO-91440: Unassigned Attribute Values Render as N/A in Product C…
04b3d46 
…omparison block

- removing if that doesn't check the first item
merge magento/2.3-develop into magento-honey-badgers/MAGETWO-91440-un…
df7edb6 
…assigned-attribute-n-a
@cpartica
Merge remote-tracking branch 'mainline/2.3-develop' into MAGETWO-9144…
9be22d7 
…0-unassigned-attribute-n-a
@cpartica
Merge branch 'MAGETWO-91440-unassigned-attribute-n-a' of github.com:m…
d5ee97a 
…agento-honey-badgers/magento2ce into MAGETWO-91440-unassigned-attribute-n-a
@cpartica
Merge pull request magento#2576 from magento-honey-badgers/MAGETWO-91…
3df6681 
…440-unassigned-attribute-n-a

[honey] Bug Fixes
MAGETWO-90358: Auto-generate ExtensionAttributes object
f9db7a0
MAGETWO-90358: Auto-generate ExtensionAttributes object
b421fa7
MAGETWO-90358: Auto-generate ExtensionAttributes object
f9903be
@paliarush
Merge pull request magento#2592 from magento-architects/MAGETWO-90358…
3d2d072 
…-Extension-Attributes

[architects] MAGETWO-90358: Auto-generate ExtensionAttributes object
@paliarush
ENGCOM-1661: [Forwardport] typo correction magento#15466
6747251
@paliarush
ENGCOM-1652: ADHOC: update the contribution templates to include a no…
551a424 
…te on results magento#15450
@magento-engcom-team
🔃 [EngCom] Public Pull Requests - 2.3-develop
7532620 
Accepted Public Pull Requests:
 - magento#15466: [Forwardport] typo correction (by @mzeis)
 - magento#15450: ADHOC: update the contribution templates to include a note on results (by @dmanners)
ENGCOM-1653: 15210-Fixed product tier pricing pagination issue in admin
7f65902 
magento#15360
@magento-engcom-team
ENGCOM-1669: Return tag misspelled magento#15492
ef1b9b1 
 - Merge Pull Request magento#15492 from lfluvisotto/magento2:2.3-develop-return-tag-misspelled
 - Merged commits:
   1. 8e14879
@magento-engcom-team
ENGCOM-1670: Duplicate array keys magento#15489
125044d 
 - Merge Pull Request magento#15489 from lfluvisotto/magento2:2.3-develop-duplicate-array-keys
 - Merged commits:
   1. 9ebdcc5
ENGCOM-1670: Duplicate array keys magento#15489
7d26829
ENGCOM-1669: Return tag misspelled magento#15492
1f1e1a0
@magento-engcom-team
🔃 [EngCom] Public Pull Requests - 2.3-develop
bed17e0 
Accepted Public Pull Requests:
 - magento#15360: 15210-Fixed product tier pricing pagination issue in admin (by @saravananvelu)
 - magento#15489: Duplicate array keys (by @lfluvisotto)
 - magento#15492: Return tag misspelled (by @lfluvisotto)


Fixed GitHub Issues:
 - magento#15210: Advanced pricing pagination issue (reported by @dryadav) has been fixed in magento#15360 by @saravananvelu in 2.3-develop branch
   Related commits:
     1. cad44a3
     2. 560aa38
     3. 8a8ed66
     4. ba6bf77
     5. 6de6006
     6. ec3eb1a
     7. 75960ce
@abcpremium
Fix HTML syntax in report.phtml error template
46165ab 
Added missing quotes to the div tags with class "control".
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.